Don't append garbage data to tag names #161
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug was introduced in OSGeo/gdal@662729c The string should be terminated at the end of the entire shared buffer. Rather, it should be terminated at the index after copying stops. This commit restores the original behaviour before 662729c Moving the index variable into the for-loop scope is a good practice in general, but not in this particular case
|
@schwehr Looks related to one of your commits. Given the date the issue is probably in the 2.1 branch as well |
|
Thanks for the fix! Committed: |
rouault
added a commit
that referenced
this pull request
Oct 21, 2016
git-svn-id: https://svn.osgeo.org/gdal/trunk@35848 f0d54148-0727-0410-94bb-9a71ac55c965
|
@schwehr No prob, anytime! I work with GDAL a lot, so I'm aware of quite a few small issues like this. However, I haven't gotten around to submitting patches before, since it's a bit cumbersome to raise/follow issues in trac. Anyway, hopefully I'll be able to submit plenty of fixes in the future! |
|
@TheDorkKnight , Great! Looking forward to more patches. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug was introduced in 662729c
The string should not be terminated at the end of the entire shared buffer. Rather, it should be terminated at the index after the end of the copied string.
This commit restores the original behaviour before 662729c
Moving the index variable into the for-loop scope is a good practice in general, but it introduced a bug in this particular case.
Example of bug:
A key like:
addr:housenumberbecomes
addr_housenumber ¬’/or something like that, since the bytes after
'r'are undefined until byte number 255.