Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve OGR CAD driver #172

Closed
wants to merge 8 commits into from
Closed

Improve OGR CAD driver #172

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4170d57
Add more code pages for text recoding
perob Nov 29, 2016
78561eb
Fix infinite loop when reading layer table
perob Nov 29, 2016
38f6d8d
Add CRC validation for headervars, classes and objects
perob Nov 29, 2016
a1dc520
Fix undefined encodings (correct array ordering)
perob Nov 30, 2016
a808c38
Fix array initializer
perob Nov 30, 2016
2bae23e
Remove explicit array initializer
perob Nov 30, 2016
90eb510
Merge branch 'trunk' into dwgcrc
perob Nov 30, 2016
fe619c9
Merge trunk, resolve conflict
perob Dec 8, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion gdal/ogr/ogrsf_frmts/cad/ogrcaddriver.cpp
View file
Open in desktop
Expand Up @@ -150,7 +150,7 @@ void RegisterOGRCAD()

CPLString CADRecode( const CPLString& sString, int CADEncoding )
{
const char* pszSource[44] = {
const char* pszSource[45] = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we just remove the explicit number ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure no problem

/* 0 UNDEFINED */ "",
/* 1 ASCII */ "US-ASCII",
/* 2 8859_1 */ "ISO-8859-1",
Expand Down