Fix or tag as allowed all uses of unsigned integer overflow, add add -fsanitize=unsigned-integer-overflow to the Travis sanitize configuration #1782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That PR might be a bit controversial as it effectively "bans" a well-defined behaviour of C/C++, that is underflow/overflow on unsigned integer arithmetic. However there are potential for real bugs to be hidden by such a behaviour (I or other contributors fixed a few instances of that in a few previous commits), so it seems reasonable to try to avoid it when possible, and when not possible, to tag the functions where this is explicitly allowed with CPL_NOSANITIZE_UNSIGNED_INT_OVERFLOW |
abellgithub
reviewed
Aug 16, 2019
…-fsanitize=unsigned-integer-overflow to the Travis sanitize configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.