Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch: s57objectclasses.csv for distance marks from IENC [add wtwdis;… #2123

Merged
merged 3 commits into from
Dec 19, 2019

Conversation

j-b-grenouille
Copy link
Contributor

… unlocd]

What does this PR do?

What are related issues/pull requests?

Tasklist

  • ADD YOUR TASKS HERE
  • Add test case(s)
  • Review
  • Adjust for comments
  • All CI builds and checks have passed

Environment

Provide environment details, if relevant:

  • OS:
  • Compiler:

@rouault
Copy link
Member

rouault commented Dec 19, 2019

Can you edit the commit message with complementary information provided in the gdal-dev thread ?
The "patch: " prefix in the commit message isn't needed

Wulf Coulmann added 2 commits December 19, 2019 16:06
> Where does this come from ? I can't see that on http://www.s-57.com/ . Or are
> they specific to the particular profile of S57 you use ?

I also searched at http://www.s-57.com/ without success.

also:
  http://www.unece.org/fileadmin/DAM/trans/doc/finaldocs/sc3/TRANS-SC3-156s2apAe.pdf
  does not mention wtwdis or unlocd as attribut for dismar, but mention it as Attribut
  but I may not really understand the standard ...

I found the values by inspecting the object with opencpn as chart-viewer

The s57 data are the official inland waterway maps from the german waterway
administration. They are provided free of charge. (I'm a professional
inland waterway skipper, we must use this data by low for ECDIS (chart
display of AIS data) on all vessels longer than 20 m)

e.g. Mittellandkanal https://en.wikipedia.org/wiki/Mittelland_Canal
  https://www.elwis.de/DE/dynamisch/IENC/download_commit.php?file=WW41_2018-06-22_0_318

or an overview at:
  https://www.elwis.de/DE/Service/Inland-ENC-der-WSV/Inland-ENC-der-WSV-node.html

or an example without the hassel of extracting
  http://gpl.coulmann.de/tmp/1W7ML310.000

The chart holds river kilometers with not physically installed distance
marks. I like to use this for personal interest for locking up the
nearest river kilometer if I have an AIS gps position of a vessel.

With the patch I can export this data
…ouille/gdal into wtwdis_unlocd_for_distance_mark
@rouault rouault merged commit ada858b into OSGeo:master Dec 19, 2019
@j-b-grenouille j-b-grenouille deleted the wtwdis_unlocd_for_distance_mark branch March 3, 2020 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants