Include gdal-config --cflags
when building Python bindings
#258
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Python bindings didn't build out of the box in some environments,
for example Ubuntu 16.04 with standard libgdal-dev package installed.
It's because Ubuntu decides to put header files in /usr/include/gdal.
gdal-config --cflags
on Ubuntu correctly has a matching includeflag but the setup script didn't make use of this.
This adds cflags from gdal-config as compiler args to extensions.
This also gets rid of sketchy retry logic when calling gdal-config.
The previous way of failing silently after retrying once doesn't
seem useful and breaks things if gdal-config is called multiple
times.
Fixes https://trac.osgeo.org/gdal/ticket/7118