Opals tuw no std string symbols

[opalsTUW]

resolution for defect #7254

[rouault]

This change the current behaviour of GDAL. Is it needed ? If such, then please revert the logic with for example #ifndef GDAL_IMPORTS

[opalsTUW]

Sorry, GDAL_EXPORTS is a define that is specific to our build environment.

However, I believe that the introduction of GDAL_IMPORTS would break application code.

Instead, I think that DLLBUILD, configured in nmake.opt should be used. Hence, in total:

#ifndef CPL_DLL
#if defined(_MSC_VER)
#  ifdef DLLBUILD
#    define CPL_DLL __declspec(dllexport)
#  elif !defined(CPL_DISABLE_DLL)
#    define CPL_DLL __declspec(dllimport)
#  else
#    define CPL_DLL
#  endif
#else
#  if defined(USE_GCC_VISIBILITY_FLAG)
#    define CPL_DLL     __attribute__ ((visibility("default")))
#  else
#    define CPL_DLL
#  endif
#endif
#endif

Is that fine?

[rouault]

Could you just revert that change ? I think for your purposes adding -DCPL_DLL= or -DCPL_DLL=__declspec(dllimport) to your nmake.opt should be enough

[rouault]

Doxygen warning : "/home/travis/build/OSGeo/gdal/gdal/port/cpl_string.h:359: warning: Member CPLStringT (define) of file cpl_string.h is not documented"

I'd suggest not to document it actually with

/*! @cond Doxygen_Suppress */
#  define CPLStringT CPLString
/*! @endcond */

[rouault]

Breaks compilation on Windows: see https://ci.appveyor.com/project/OSGeo/gdal/build/1.0.4840/job/rkxg6lubkavb188v

[rouault]

Please move that "//! Convenient string class based on std::string" Doxygen line just before "class CPL_DLL CPLString : public std::string", so as to fix the "cpl_string.h:366: warning: Compound CPLString is not documented." cppcheck error