Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GeoPackage: Fix handling of invalid SRS ID when writing #3312

Merged

Conversation

mloskot
Copy link
Member

@mloskot mloskot commented Dec 21, 2020

What does this PR do?

Improve the writing side of the GeoPackage driver in order to support round-trip of the two special undefined SRS-s.

What are related issues/pull requests?

Tasklist

  • Add test case(s)
  • Add documentation
  • Review
  • Adjust for comments
  • All CI builds and checks have passed

@rouault
Copy link
Member

rouault commented Dec 21, 2020

#3313 might fix the test failure you have

@mloskot mloskot force-pushed the ml/geopackage-fix-undefined-srs-id-writing branch from 0e59aed to e561d34 Compare December 22, 2020 08:39
@mloskot
Copy link
Member Author

mloskot commented Dec 22, 2020

I've rebased onto the latest master, let's see.

@mloskot mloskot requested a review from rouault December 22, 2020 09:32
autotest/gdrivers/gpkg.py Outdated Show resolved Hide resolved
autotest/ogr/ogr_gpkg.py Outdated Show resolved Hide resolved
@mloskot mloskot force-pushed the ml/geopackage-fix-undefined-srs-id-writing branch from e561d34 to 69aebed Compare December 22, 2020 11:09
@mloskot mloskot requested a review from rouault December 22, 2020 11:10
@rouault rouault added this to the 3.3.0 milestone Dec 22, 2020
@rouault
Copy link
Member

rouault commented Dec 22, 2020

Merged. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GeoPackage: Fix handling of invalid SRS ID when writing
2 participants