Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NITF: expose ISUBCAT for each band (if non-empty) #4028

Merged
merged 10 commits into from
Jun 24, 2021
Merged

NITF: expose ISUBCAT for each band (if non-empty) #4028

merged 10 commits into from
Jun 24, 2021

Conversation

andrew-hardin
Copy link
Contributor

@andrew-hardin andrew-hardin commented Jun 23, 2021 •
edited

What does this PR do?

This PR adds a new metadata field if it's non-empty: NITF_ISUBCAT. This is extremely useful for understanding the band content of SAR imagery. For example:

# gdalinfo data/nitf/sar_sicd.ntf
Band 1 [...]
  Metadata:
    NITF_ISUBCAT=I
Band 2 [...]
  Metadata
    NITF_ISUBCAT=Q

What are related issues/pull requests?

Tasklist

  • Add test case(s)
  • Add documentation
  • Review
  • Adjust for comments
  • All CI builds and checks have passed

rouault
rouault reviewed Jun 23, 2021
View reviewed changes
gdal/frmts/nitf/nitfdataset.cpp Outdated Show resolved Hide resolved
gdal/frmts/nitf/nitfdataset.cpp Outdated Show resolved Hide resolved
gdal/frmts/nitf/nitfdataset.cpp Outdated Show resolved Hide resolved
andrew-hardin and others added 3 commits June 23, 2021 15:52
@andrew-hardin @rouault
Update gdal/frmts/nitf/nitfdataset.cpp
6a1a40c 
Co-authored-by: Even Rouault <even.rouault@spatialys.com>
@andrew-hardin @rouault
Update gdal/frmts/nitf/nitfdataset.cpp
7a8173c 
Co-authored-by: Even Rouault <even.rouault@spatialys.com>
@andrew-hardin @rouault
Update gdal/frmts/nitf/nitfdataset.cpp
3a28d12 
Co-authored-by: Even Rouault <even.rouault@spatialys.com>
@rouault rouault added this to the 3.4.0 milestone Jun 24, 2021
@rouault rouault merged commit dee621e into OSGeo:master Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rouault rouault rouault left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andrew-hardin @rouault