Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC 84: Migrating build systems to CMake #4590

Merged
merged 4 commits into from
Oct 18, 2021
Merged

Conversation

rouault
Copy link
Member

@rouault rouault commented Oct 4, 2021

@gdt
Copy link
Contributor

gdt commented Oct 5, 2021

This is missing a requirements section, that states what the new build system is expected to do before it is considered ready, i.e. preconditions for removing autoconf. I think that includes at least

  • build system works on all systems where the autoconf build is known to work (even if not in CI)
  • supports objdir builds
  • supports cross builds
  • cmakefiles do not contain "ifdef FooOS", except possibly to add a workaround instead of assuming POSIX when FooOS is known not to meet posix. For any optional things, they need to have feature tests. (autoconf culture is to use feature tests, and in packaging various things I have come across many many OS-specific ifdefs that grow to a long list.)
  • there's been a formal release with autoconf and cmake where cmake meets the above requirements, as verified by packager feedback.

@rouault rouault merged commit a4bfcbf into OSGeo:master Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants