Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GRIB: fix thread-safetey of errSprintf() #4830

Merged
merged 2 commits into from Nov 16, 2021

Conversation

rouault
Copy link
Member

@rouault rouault commented Nov 15, 2021

Should fix (or at least help..) for the scenario of
https://lists.osgeo.org/pipermail/gdal-dev/2021-November/055009.html

@rouault rouault force-pushed the fix_grib_errSprintf_thread_safety branch from 93ff544 to 1062541 Compare November 15, 2021 19:47
frmts/grib/degrib/degrib/myerror.cpp Outdated Show resolved Hide resolved
Co-authored-by: Nyall Dawson <nyall.dawson@gmail.com>
@rouault rouault merged commit f254d76 into OSGeo:master Nov 16, 2021
@github-actions
Copy link

The backport to release/3.4 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release/3.4 release/3.4
# Navigate to the new working tree
cd .worktrees/backport-release/3.4
# Create a new branch
git switch --create backport-4830-to-release/3.4
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 f254d76f1bed9c2787f17ae4d08562197286b2fd
# Push it to GitHub
git push --set-upstream origin backport-4830-to-release/3.4
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release/3.4

Then, create a pull request where the base branch is release/3.4 and the compare/head branch is backport-4830-to-release/3.4.

rouault added a commit to rouault/gdal that referenced this pull request Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants