Add option to use input nodata value in ComputeProximity #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rouault I opted to keep USE_INPUT_NODATA=NO as the default, since that keeps the default behaviour the same, but changed the semantics like you suggested and updated the docs & tests. |
|
@rouault Is there anything else this patch requires? |
kwrobot
pushed a commit
to aashish24/gdal-svn
that referenced
this pull request
Apr 9, 2015
…Daniel Evans, OSGeo/gdal#49) git-svn-id: https://svn.osgeo.org/gdal/trunk/gdal@28882 f0d54148-0727-0410-94bb-9a71ac55c965
|
trunk r28882 "Proximity alg/gdal_proximity: add a -use_input_nodata flag (patch by Daniel Evans, #49)" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies handling of nodata values in my case, as areas of nodata don't have to be filtered out at a later stage.
The change shouldn't break any existing workflow, as using the input nodata into account must be enabled explicitly.
Functionality is possibly related to http://trac.osgeo.org/gdal/ticket/5862.