WFS/CSW: do not remove single or double quote character in a LIKE filter #6713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously for a filter ``foo LIKE '"in double quotes"'`` or ``foo LIKE '''in single quotes '''``, the surrounding double/single quotes inside the literal strings were removed. The erroneous behaviour was introduced in 08b1fad where a re-write was done from a hand-made SQL parser to using the OGR SQL one, but the code to deal with literal quoting should have been removed. Fixes https://lists.osgeo.org/pipermail/gdal-dev/2022-November/056447.html
rouault
force-pushed
the
wfs_filter_quote
branch
from
38837d3
to
a01d852
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously for a filter
foo LIKE '"in double quotes"'orfoo LIKE '''in single quotes ''', the surrounding double/single quotes inside the literal strings were removed.The erroneous behaviour was introduced in 08b1fad where a re-write was done from a hand-made SQL parser to using the OGR SQL one, but the code to deal with literal quoting should have been removed.
Fixes https://lists.osgeo.org/pipermail/gdal-dev/2022-November/056447.html