GPKG: fix threaded RTree building when creating several layers (3.6.0 regression) #6959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rouault
force-pushed
the
gpkg_fix_async_multiple_layers
branch
from
ed4721a
to
b359d22
Compare
… regression) Before this fix, an error message like "sqlite3_exec(ATTACH DATABASE 'my.gpkg.tmp_rtree_bar.db' AS temp_rtree) failed: database temp_rtree is already in use" was emitted. Luckily, the code detects this error and falls back to the non-threaded RTree implementation, so no data corruption occurs. Just an annoying error message, and a suboptimal behaviour since only the first layer is created with threaded RTree building.
rouault
force-pushed
the
gpkg_fix_async_multiple_layers
branch
from
b359d22
to
08841c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Async RTree building doesn't play well with multiple layers: SQLite3 locks being hold for a long time, random failed commits, etc