Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DIMAP: Correctly set RPC origin for SPOT, PHR and PNEO #7653

Merged
merged 2 commits into from
May 9, 2023

Conversation

tbonfort
Copy link
Member

Rework #5725 to set RPC origin from the sensor profile instead of from the ImagetoGround_Validity_Domain

cc @Lunyxis @jguinet

For reference: #5716 and https://lists.osgeo.org/pipermail/gdal-dev/2015-June/042090.html

@tbonfort tbonfort marked this pull request as draft April 28, 2023 10:54
@jguinet
Copy link

jguinet commented Apr 28, 2023

Good idea. ImagetoGround_Validity_Domain can theorically starts at a non origin position.

#5725 (comment)

@rouault
Copy link
Member

rouault commented May 2, 2023

@tbonfort anything missing for this PR to be mergeable ?

@tbonfort
Copy link
Member Author

tbonfort commented May 3, 2023

@rouault I'm off work this week, this pr can be included as is if you want to include it in the 3.7 release candidates. I still have a small batch of refactorings with no functional change to add to it but they can come in a subsequent pr.

@tbonfort tbonfort marked this pull request as ready for review May 3, 2023 19:11
@tbonfort
Copy link
Member Author

tbonfort commented May 3, 2023

ha, sorry, I just saw Im late to the game as the rc has already been released. So this pr is a candidate for rc2 if it were to exist but does not warrant an rc2 as of itself

@rouault
Copy link
Member

rouault commented May 9, 2023

Merging this, and tagging it for backport for 3.7.1

@rouault rouault merged commit af5aa16 into OSGeo:master May 9, 2023
29 checks passed
@rouault
Copy link
Member

rouault commented Jul 24, 2023

@tbonfort @Lunyxis @jguinet A user is reporting in https://lists.osgeo.org/pipermail/gdal-dev/2023-July/057505.html that it seems that this changes causes a regression with some PNEO images whose ImagetoGround_Validity_Domain.FIRST_COL/FIRST_ROW are negative

@tbonfort
Copy link
Member Author

@rouault thanks, I've followed up off list with him and will report back with the outcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants