Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VSICurl and derived: replace most uses of CPLString with std::string #9003

Merged
merged 4 commits into from
Dec 29, 2023
Merged

VSICurl and derived: replace most uses of CPLString with std::string #9003

merged 4 commits into from
Dec 29, 2023

Conversation

rouault
Copy link
Member

@rouault rouault commented Dec 26, 2023

and a few coverity fixes

@coveralls
Copy link
Collaborator

coveralls commented Dec 26, 2023 •
edited

Coverage Status

coverage: 68.738% (+0.003%) from 68.735%
when pulling d4683fa on rouault:coverity_fixes
into f90b902 on OSGeo:master.

elpaso
elpaso approved these changes Dec 28, 2023
View reviewed changes
Copy link
Collaborator

@elpaso elpaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that moving away from CPLString is a good move but can you explain me what is the long term strategy?

Is the CPL* a legacy of the past when the standard library wasn't mature (or even existing)?

Is it the goal to eventually drop CPL completely?

ogr/utf8.h Outdated Show resolved Hide resolved
@rouault
Copy link
Member Author

rouault commented Dec 28, 2023

Is it the goal to eventually drop CPL completely?

no, I don't think so as it provides useful utilities. But using plain std::string when we don't need CPLString makes sense.

@rouault rouault merged commit abd6620 into OSGeo:master Dec 29, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elpaso elpaso elpaso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rouault @coveralls @elpaso