BMP: fix reading images larger than 4GB #9168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a regression introduced in GDAL 3.4.0 per OSGeo#4720
elpaso
approved these changes
Feb 1, 2024
|
I thought that BMP cannot be larger that 4 GB https://www.artwork.com/gerber/vlbv/faq/bmp_header.htm but obviously it can. Is the specification changed at some time? |
I don't know if the spec allows it but GDAL has never limited it. But I would assume most BMP viewer will struggle with such large files. GDAL writes a dummy 0xFFFFFFF value in the header field where the file size is written, and on reading it ignores it. Cf c2b55fe for a related past changes (but writing and reading files larger than 4 GB was older than this one) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression introduced in GDAL 3.4.0 per #4720