Make sure our vendored flatbuffers copy has a unique namespace #9313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rouault
changed the title
rouault
force-pushed
the
flatbuffers_namespacing
branch
from
493797f
to
0ecf0c6
Compare
rouault
added a commit
to rouault/postgis
that referenced
this pull request
Feb 26, 2024
rouault
force-pushed
the
flatbuffers_namespacing
branch
from
0ecf0c6
to
f304ca5
Compare
rouault
added a commit
to rouault/postgis
that referenced
this pull request
Feb 26, 2024
|
That's even hackier than how I fixed it locally, but at least I picked the same name! :) |
|
Looks sensible to me |
elpaso
approved these changes
Feb 26, 2024
robe2
pushed a commit
to postgis/postgis
that referenced
this pull request
Feb 26, 2024
robe2
pushed a commit
to postgis/postgis
that referenced
this pull request
Feb 26, 2024
robe2
pushed a commit
to postgis/postgis
that referenced
this pull request
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cf https://lists.osgeo.org/pipermail/gdal-dev/2024-February/058544.html