/vsis3/: include AWS_CONTAINER_CREDENTIALS_TOKEN in container credentials flow #9877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jesseanttila-cai
commented
May 8, 2024
jesseanttila-cai
force-pushed
the
container_credentials
branch
from
38e7ec9
to
622ac6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR extends the container credentials functionality of
vsis3to cover more cases, particularly EKS Pod Identities.Two additional environment variables are now considered in the container credentials flow:
AWS_CONTAINER_AUTHORIZATION_TOKEN_FILEandAWS_CONTAINER_AUTHORIZATION_TOKEN, with the former taking precedence over the latter (as described in AWS SDK documentation).In addition to the included tests, I have tested the
AWS_CONTAINER_AUTHORIZATION_TOKEN_FILE-based credential flow in practice on EKS.What are related issues/pull requests?
This functionality has been previously improved in #8859
Tasklist