Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MiraMonVector: adding which polygon cycles the linestring in the linestring metadata information #9883

Merged
merged 2 commits into from
May 9, 2024
Merged

MiraMonVector: adding which polygon cycles the linestring in the linestring metadata information #9883

merged 2 commits into from
May 9, 2024

Conversation

AbelPau
Copy link
Contributor

@AbelPau AbelPau commented May 9, 2024 •
edited

What does this PR do?

Fix: adding which polygon cycles the stringline in the stringline metadata information

It's not an error but it's useful metadata information.

Tasklist

  • Make sure code is correctly formatted (cf pre-commit configuration)
  • Almost all CI builds and checks have passed
  • Confirm that Linux Builds / Alpine gcc failure is not this pull request fault.

@coveralls
Copy link
Collaborator

coveralls commented May 9, 2024 •
edited

Coverage Status

coverage: 69.089% (-0.003%) from 69.092%
when pulling a2c8071 on AbelPau:MiraMonVector-Fixing-a-metadata-issue
into 3d96b17 on OSGeo:master.

@AbelPau AbelPau changed the title MiraMonVector: adding which polygon cycles the stringline in the stringlinemetadata information MiraMonVector: adding which polygon cycles the stringline in the stringline metadata information May 9, 2024
@AbelPau AbelPau changed the title MiraMonVector: adding which polygon cycles the stringline in the stringline metadata information MiraMonVector: adding which polygon cycles the linestring in the linestring metadata information May 9, 2024
@AbelPau
Copy link
Contributor Author

AbelPau commented May 9, 2024 •
edited

@rouault It seems that Linux Builds / Alpine, gcc fails for a problem out of this PR scope. Is this true?

@AbelPau AbelPau marked this pull request as ready for review May 9, 2024 11:06
@AbelPau
Copy link
Contributor Author

AbelPau commented May 9, 2024

@rouault It seems that Linux Builds / Alpine, gcc fails for a problem out of this PR scope. Is this true?

It seems thant a second try has make it pass.

@rouault rouault merged commit 7da98cd into OSGeo:master May 9, 2024
35 checks passed
@rouault rouault mentioned this pull request May 9, 2024
Merged
@AbelPau AbelPau deleted the MiraMonVector-Fixing-a-metadata-issue branch May 10, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rouault rouault rouault left review comments

Assignees
No one assigned
Labels
backport release/3.9
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AbelPau @coveralls @rouault