Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OGRSQL: validate column name in COUNT(field_name) #9986

Merged
merged 1 commit into from
May 28, 2024
Merged

OGRSQL: validate column name in COUNT(field_name) #9986

merged 1 commit into from
May 28, 2024

Conversation

rouault
Copy link
Member

@rouault rouault commented May 22, 2024

and error out if it doesn't exist, otherwise it evaluates as COUNT(*)

Fixes #9972

@rouault
OGRSQL: validate column name in COUNT(field_name)
d0c49b7 
and error out if it doesn't exist, otherwise it evaluates as COUNT(*)

Fixes OSGeo#9972
@coveralls
Copy link
Collaborator

Coverage Status

coverage: 69.131%. remained the same
when pulling d0c49b7 on rouault:fix_9972
into 77031d7 on OSGeo:master.

@rouault rouault merged commit 4d760e1 into OSGeo:master May 28, 2024
36 checks passed
@rouault rouault mentioned this pull request May 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport release/3.9
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

-dialect OGRSQL: COUNT does not validate the column name
2 participants
@rouault @coveralls