Skip to content

Commit

Permalink
Adding tarfile member sanitization to extractall()
Browse files Browse the repository at this point in the history
  • Loading branch information
TrellixVulnTeam committed Dec 21, 2022
1 parent 90ce5b7 commit 0f4b8cb
Showing 1 changed file with 20 additions and 1 deletion.
21 changes: 20 additions & 1 deletion src/imagery/i.landsat/i.landsat.import/i.landsat.import.py
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,26 @@ def _untar(inputdir, untardir):

for scene in scenes_to_untar:
with tarfile.open(name=scene, mode="r") as tar:
tar.extractall(untardir)
def is_within_directory(directory, target):

abs_directory = os.path.abspath(directory)
abs_target = os.path.abspath(target)

prefix = os.path.commonprefix([abs_directory, abs_target])

return prefix == abs_directory

def safe_extract(tar, path=".", members=None, *, numeric_owner=False):

for member in tar.getmembers():
member_path = os.path.join(path, member.name)
if not is_within_directory(path, member_path):
raise Exception("Attempted Path Traversal in Tar File")

tar.extractall(path, members, numeric_owner=numeric_owner)


safe_extract(tar, untardir)

untared_tifs = glob.glob(os.path.join(untardir, "*.TIF"))
return untared_tifs
Expand Down

0 comments on commit 0f4b8cb

Please sign in to comment.