Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i.sentinel: easier computing shadows #137

Merged
merged 12 commits into from
Apr 6, 2020
Merged

i.sentinel: easier computing shadows #137

merged 12 commits into from
Apr 6, 2020

Conversation

anikaweinmann
Copy link
Contributor

i.sentinel.mask needs the MTD_TL.xml file. The used information are also written by i.sentinel.import with r.support in the metadata of the bands.
Since, the metadata cannot be parsed properly due to wrong line breaks, you can now create a json dump metadata file by i.sentinel.import and use it in i.sentinel.mask.

@neteler neteler requested a review from RobiFag April 2, 2020 12:05
anikaweinmann and others added 2 commits April 2, 2020 14:16
@anikaweinmann @neteler
Update grass7/imagery/i.sentinel/i.sentinel.mask/i.sentinel.mask.py
a11df09 
Co-Authored-By: Markus Neteler <neteler@gmail.com>
@anikaweinmann @neteler
Update grass7/imagery/i.sentinel/i.sentinel.mask/i.sentinel.mask.py
1efa44b 
Co-Authored-By: Markus Neteler <neteler@gmail.com>
@anikaweinmann @neteler
Update grass7/imagery/i.sentinel/i.sentinel.mask/i.sentinel.mask.py
af7136d 
Co-Authored-By: Markus Neteler <neteler@gmail.com>
@ninsbl
Copy link
Member

ninsbl commented Apr 2, 2020

FYI: I do have a (not yet committed) raster based computation of cloud shadows (derived from this module) that can speedup the process significantly, esp. for higher cloud coverage with many cloud areas...
Will try to get a test version out ASAP.

This was referenced Apr 4, 2020
Closed
Closed
@neteler neteler mentioned this pull request Apr 5, 2020
Merged
@neteler
Copy link
Member

neteler commented Apr 6, 2020

@AnikaBettge please let me know when you think it is ready for merge,

@anikaweinmann
Copy link
Contributor Author

@neteler I think it is now ready for merge

neteler
neteler approved these changes Apr 6, 2020
View reviewed changes
Copy link
Member

@neteler neteler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement!

@neteler neteler merged commit 3d2cca9 into OSGeo:master Apr 6, 2020
@veroandreo
Copy link
Contributor

This is a great improvement and I know this is merged already, but how are we supposed to easily know the name of the json dump to use it as input for i.sentinel.mask? Do we need to browse in the mapset files or does it get printed when i.sentinel.import finishes? An extra example for this use case would be highly appreciated and would also make the improvement more visible and discoverable by users

@veroandreo veroandreo mentioned this pull request Apr 14, 2020
Open
landam pushed a commit to landam/grass-addons that referenced this pull request Dec 10, 2020
@anikaweinmann @neteler @landam
i.sentinel: easier computing shadows (OSGeo#137)
b35bbd4 
* add metadata json dump file for shadow computing
* Update grass7/imagery/i.sentinel/i.sentinel.mask/i.sentinel.mask.py
* write same number of files -j and metadata
* change standard json folder to cell_misc/RASTERNAME

Co-authored-by: Markus Neteler <neteler@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ninsbl ninsbl ninsbl left review comments

@RobiFag RobiFag RobiFag left review comments

@metzm metzm metzm left review comments

@neteler neteler neteler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@anikaweinmann @ninsbl @neteler @veroandreo @RobiFag @metzm