wxGUI wx.metadata: Fix launch g.gui.metadata, g.gui.cswbrowser #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lisher class init)
…AddSpacer method (minim. vertical space between widgets)
…rom ScrolledPanel widget during scrolling
… with arg (rectangle polygon)
|
I fixed all the errors during the installation of the add-on. It is currently possible to install the add-on correctly. |
neteler
reviewed
Jun 26, 2020
|
|
||
| #from pydispatch import dispatcher | ||
| # from pydispatch import dispatcher |
There was a problem hiding this comment.
Suggested change
| # from pydispatch import dispatcher | |
| # from pydispatch import dispatcher | |
| #%module | |
| #% description: Graphical ISO/INSPIRE metadata editor. | |
| #% keyword: general | |
| #% keyword: GUI | |
| #% keyword: metadata | |
| #%end |
Silence: "WARNING: Bug in UI description. Missing module description"
--> might be extended
|
Thanks for your enormous efforts to update this suite! Just two minor warnings I got, which might be fixed as well: |
neteler
reviewed
Jun 26, 2020
|
|
||
| from grass.pygrass.utils import set_path | ||
| set_path(modulename='wx.metadata', dirname='mdlib') | ||
| from mdlib.cswlib import CSWBrowserPanel, CSWConnectionPanel | ||
|
|
||
| import wx |
There was a problem hiding this comment.
Suggested change
| import wx | |
| import wx | |
| #%module | |
| #% description: Graphical CSW metadata browser. | |
| #% keyword: general | |
| #% keyword: GUI | |
| #% keyword: metadata | |
| #%end |
Silence: "WARNING: Bug in UI description. Missing module description"
--> might be extended
|
I started with testing and got some issues: My setup:
Tests with nc_spm_08_grass7 data (zip): |
|
More testing: GUI
Wish: change to "Busy" cursor when clicking on the "search" button (I guess somewhere near Bug: when clicking on one of the datasets listed under "results": The missing file is indeed installed in |
|
More testing:
(following https://grasswiki.osgeo.org/wiki/ISO/INSPIRE_Metadata_Support#GRASS_metadata_map_editor and https://www.youtube.com/watch?v=7V5NyVdO05o) Initial layout issueWhen opening
After a window resize is becomes right:
UsageNext step is to select a map from the layer tree and click on "Template". This will open a new dialog. Here I get (not sure what it means to me): Next one gets into the editing mode to populate the metadata fields. Here also the layout isn't fully right (resizing the window fixes it by apparently refreshing it):
to then become the expected:
In the terminal I got this error: (I'll continue later with testing) |
…he search btn widget
…stCtrl widget result item
You are welcome. I fixed it. |
I fixed it (bugs related with launching |
I Implemented it (busy cursor).
I can't reproduce it. I got following error only.
|
|
@tmszi - what about merging for now and then continue in a separate PR? That might help with testing by others being less familiar with locally applying PR changes... (just an idea). |
Good idea, I merged it. |
It is still open and not yet merged ... :-) on purpose? |
Yes, you are right. I just noticed (as you alerted me) that the only allowed merge option is squash and merge. I tried rebase and merge via cmd and than push. It did not print any warning that the option is not allowed. Should I do it through the squash and merge option? |
|
Yes, please. |
landam
pushed a commit
to landam/grass-addons
that referenced
this pull request
Nov 19, 2020
…#222) * wx.metadata/g.gui.metadata: fix wx.FileDialog widget window style * wx.metadata/g.gui.metadata: fix event handler function binding * wx.metadata/g.gui.metadata: fix CustomTreeCtrl widget GetSelections method * wx.metadata/mdlib: fix removeNonAscii function return value * wx.metadata/mdlib: fix encode string * wx.metadata/mdlib: fix wx.BoxSizer widget Add method params * wx.metadata/g.gui.metadata: remove add left wx.Panel widget into wx.BoxSizer widget * wx.metadata/g.gui.metadata: update wx.SplitterWindow widget size * wx.metadata/mdlib: increase plus/minus wx.Button widget size (show label) * wx.metadata/g.gui.metadata, mdlib: fix wx.BoxSizer widget add spacer with Add method * wx.metadata/mdlib: fix wx.ListCtrl widget wxPyDeprecationWarning * wx.metadata/mdlib: fix wx.ListCtrl widget set tooltip * wx.metadata/mdlib: fix decode string * wx.metadata/mdlib: fix add web service layer * wx.metadata/mdlib: fix constraints builder dialog layout * wx.metadata/mdlib: fix constraints builder dialog constraints validation * wx.metadata/mdlib: fix slice stop index * wx.metadata/mdlib: remove unused code line * wx.metadata/mdlib: fix result list wx.ListCtrl widget vertical expand * wx.metadata/g.gui.metadata: set class config attr (req for the CswPublisher class init) * wx.metadata/g.gui.metadata, mdlib: replace add space Add method with AddSpacer method (minim. vertical space between widgets) * wx.metadata/g.gui.metadata: fix not overflow duplicated item widget from ScrolledPanel widget during scrolling * wx.metadata/mdlib: fix compare two metadata items (remove metadata item) * wx.metadata/g.gui.metadata.py: remove calling non exist method * wx.metadata/mdlib: fix pdf doc logo path * wx.metadata/mdlib: replace google api for generate static map img with osm api (https://github.com/jperelli/osm-static-maps) * wx.metadata/mdlib: fix write output pdf doc * wx.metadata/g.gui.metadata.py: fix wx.TreeCtrl widget wxPyDeprecationWarning * wx.metadata/mdlib: set static map img service url geojson query param with arg (rectangle polygon) * wx.metadata/mdlib: fix script file header, import py modules according flake8 * wx.metadata/mdlib: set static map img url debug info * wx.metadata/db.csw.admin: fix missing manual html file error during compilation * wx.metadata/mdlib: fix transform static map bounds coords to the wgs84 * wx.metadata/db.csw.admin, g.gui.cswbrowser, g.gui.metadata, t.info.iso, v.info.iso: fix import mdlib * wx.metadata/mdlib: fix missing wxgui path * wx.metadata/mdlib: fix static map zoom max value * wx.metadata: improve code of checking add-on py libs dependencies * wx.metadata/g.gui.cswbrowser, g.gui.metadata: add basic module description * wx.metadata/mdlib: fix module name * wx.metadata/mdlib: fix map name * wx.metadata/mdlib, t.info.iso, v.info.iso: fix flake8-strict errors * wx.metadata/g.gui.cswbrowser, mdlib: set busy cursor after click on the search btn widget * wx.metadata/mdlib: fix wx.ListCtrl widget wxPyDeprecationWarning * wx.metadata/g.gui.cswbrowser, mdlib: fix insert 'unknown' type, wx.ListCtrl widget result item * wx.metadata/r.info.iso: fix flake8-strict errors * wx.metadata/t.info.iso: fix write result to output file name destination
landam
pushed a commit
to landam/grass-addons
that referenced
this pull request
Dec 10, 2020
…#222) * wx.metadata/g.gui.metadata: fix wx.FileDialog widget window style * wx.metadata/g.gui.metadata: fix event handler function binding * wx.metadata/g.gui.metadata: fix CustomTreeCtrl widget GetSelections method * wx.metadata/mdlib: fix removeNonAscii function return value * wx.metadata/mdlib: fix encode string * wx.metadata/mdlib: fix wx.BoxSizer widget Add method params * wx.metadata/g.gui.metadata: remove add left wx.Panel widget into wx.BoxSizer widget * wx.metadata/g.gui.metadata: update wx.SplitterWindow widget size * wx.metadata/mdlib: increase plus/minus wx.Button widget size (show label) * wx.metadata/g.gui.metadata, mdlib: fix wx.BoxSizer widget add spacer with Add method * wx.metadata/mdlib: fix wx.ListCtrl widget wxPyDeprecationWarning * wx.metadata/mdlib: fix wx.ListCtrl widget set tooltip * wx.metadata/mdlib: fix decode string * wx.metadata/mdlib: fix add web service layer * wx.metadata/mdlib: fix constraints builder dialog layout * wx.metadata/mdlib: fix constraints builder dialog constraints validation * wx.metadata/mdlib: fix slice stop index * wx.metadata/mdlib: remove unused code line * wx.metadata/mdlib: fix result list wx.ListCtrl widget vertical expand * wx.metadata/g.gui.metadata: set class config attr (req for the CswPublisher class init) * wx.metadata/g.gui.metadata, mdlib: replace add space Add method with AddSpacer method (minim. vertical space between widgets) * wx.metadata/g.gui.metadata: fix not overflow duplicated item widget from ScrolledPanel widget during scrolling * wx.metadata/mdlib: fix compare two metadata items (remove metadata item) * wx.metadata/g.gui.metadata.py: remove calling non exist method * wx.metadata/mdlib: fix pdf doc logo path * wx.metadata/mdlib: replace google api for generate static map img with osm api (https://github.com/jperelli/osm-static-maps) * wx.metadata/mdlib: fix write output pdf doc * wx.metadata/g.gui.metadata.py: fix wx.TreeCtrl widget wxPyDeprecationWarning * wx.metadata/mdlib: set static map img service url geojson query param with arg (rectangle polygon) * wx.metadata/mdlib: fix script file header, import py modules according flake8 * wx.metadata/mdlib: set static map img url debug info * wx.metadata/db.csw.admin: fix missing manual html file error during compilation * wx.metadata/mdlib: fix transform static map bounds coords to the wgs84 * wx.metadata/db.csw.admin, g.gui.cswbrowser, g.gui.metadata, t.info.iso, v.info.iso: fix import mdlib * wx.metadata/mdlib: fix missing wxgui path * wx.metadata/mdlib: fix static map zoom max value * wx.metadata: improve code of checking add-on py libs dependencies * wx.metadata/g.gui.cswbrowser, g.gui.metadata: add basic module description * wx.metadata/mdlib: fix module name * wx.metadata/mdlib: fix map name * wx.metadata/mdlib, t.info.iso, v.info.iso: fix flake8-strict errors * wx.metadata/g.gui.cswbrowser, mdlib: set busy cursor after click on the search btn widget * wx.metadata/mdlib: fix wx.ListCtrl widget wxPyDeprecationWarning * wx.metadata/g.gui.cswbrowser, mdlib: fix insert 'unknown' type, wx.ListCtrl widget result item * wx.metadata/r.info.iso: fix flake8-strict errors * wx.metadata/t.info.iso: fix write result to output file name destination
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
g.gui.metadata:with csw dialog:
Exporting metadata reports to format PDF:
I changed the api to get static map img from google maps api to osm api (sometimes the service
https://osm-static-maps.herokuapp.comis unavailable for a short time). Currently only static map img url queryzoomparam argument is not correctly derived.Example raster Basins maps (nc_basic_spm_grass7 location) url to get static map img (Geographic Location section in the pdf doc):
https://osm-static-maps.herokuapp.com/?geojson=[{'type':'Feature','geometry':{'type':'Polygon','coordinates':[[[-78.77462049,35.68792712],[-78.60889171,35.6875073],[-78.60830318,35.80918894],[-78.77428134,35.80960938],[-78.77462049,35.68792712]]]}}]¢er=-78.69152414,35.74858701&zoom=12&size=200x200g.gui.cswbrowser:Additional info:
Tested with: