r.learn.ml2 fix import of rlearnlib

[anikaweinmann]

There were changed in the Makefile which leads to ModuleNotFoundError, because the lib path changed:

r.learn.train --help
Traceback (most recent call last):
  File "/home/mneteler/software/grass_master/dist.x86_64-pc-linux-gnu/scripts/r.learn.train", line 350, in <module>
    from rlearnlib.utils import (
ModuleNotFoundError: No module named 'rlearnlib'

These changes fix this problem.
(Developed with @griembauer)

[tmszi]

There were changed in the Makefile which leads to ModuleNotFoundError, because the lib path changed:

r.learn.train --help
Traceback (most recent call last):
  File "/home/mneteler/software/grass_master/dist.x86_64-pc-linux-gnu/scripts/r.learn.train", line 350, in <module>
    from rlearnlib.utils import (
ModuleNotFoundError: No module named 'rlearnlib'

These changes fix this problem.
(Developed with @griembauer)

Thank you very much for reporting/testing this and your time. In my previous PR commit I made a change so that the files from the directory rlearnlib were installed again in the directory rlearnlib (in my case .grass7/addons/etc/r.learn.ml2/rlearnlib/) for consistency across Add-ons installation e.g. same as at wx.metadata Add-On (mdlib dir).

tomas@gentoo-gnu-linux:~$ ls .grass7/addons/etc/r.learn.ml2/rlearnlib/
indexing.py  __pycache__  raster.py  stats.py  transformers.py  utils.py
tomas@gentoo-gnu-linux:~$

Looks like I forgot to include this change, and this patch patch.zip (one line) will fix it.

[tmszi]

This one line fix this error (previous changes isn't needed):
$(MKDIR) $(INST_DIR)/etc/r.learn.ml2/rlearnlib

[anikaweinmann]

I removed all other changes. But I do not need the -p in the Makefile, because $(MKDIR) is in my system mkdir -p and I am not sure if the -p works in other systems e.g. Windows.

I have:
Distributor ID: LinuxMint
Description: Linux Mint 19.2 Tina
Release: 19.2
Codename: tina

[tmszi]

I removed all other changes. But I do not need the -p in the Makefile, because $(MKDIR) is in my system mkdir -p and I > am not sure if the -p works in other systems e.g. Windows.

Yes you are right. According $(MKDIR) variable definition in the file Platform.make.in, mkdir command has -p flag and then no needed extra flag definition in this Makefile.

[tmszi]

Could @anikaweinmann test it and confirm that it works, please?

[anikaweinmann]

@tmszi yes it is working for me. But I'm not sure that the $(MKDIR) -p is working for every system.
On my VirtualBox with Windows I get:

[hellik]

mkdir -p isn't available in Windows, see

https://stackoverflow.com/questions/905226/what-is-equivalent-to-linux-mkdir-p-in-windows

[tmszi]

@tmszi yes it is working for me. But I'm not sure that the $(MKDIR) -p is working for every system.
On my VirtualBox with Windows I get:

Thanks for info. But Add-On installation work differently on MS Windows (precompiled packages are installed on the client, Add-On compilation takes place on the server which use OSGeo4W installer) e.g. wx.metadata Add-On use $(MKDIR) -p too, and compilation is alright according https://wingrass.fsv.cvut.cz/grass78/x86_64/addons/latest/logs/. The installation wx.metadata Add-On on MS Windows was not successful, but error not related with $(MKDIR) -p.

wx.metadata Add-On installation dir structure (mdlib 'same' as rlearnlib) and seems alright:

[anikaweinmann]

@tmszi yes it is working for me. But I'm not sure that the $(MKDIR) -p is working for every system.
On my VirtualBox with Windows I get:

Thanks for info. But Add-On installation work differently on MS Windows (precompiled packages are installed on the client, Add-On compilation takes place on the server which use OSGeo4W installer) e.g. wx.metadata Add-On use $(MKDIR) -p too, and compilation is alright according https://wingrass.fsv.cvut.cz/grass78/x86_64/addons/latest/logs/. The installation wx.metadata Add-On on MS Windows was not successful, but error not related with $(MKDIR) -p.

wx.metadata Add-On installation dir structure (mdlib 'same' as rlearnlib) and seems alright:

Okay. Then is your change fine for me.

[anikaweinmann]

I removed all other changes. But I do not need the -p in the Makefile, because $(MKDIR) is in my system mkdir -p and I am not sure if the -p works in other systems e.g. Windows.

I have:
Distributor ID: LinuxMint
Description: Linux Mint 19.2 Tina
Release: 19.2
Codename: tina

[tmszi]

@tmszi yes it is working for me. But I'm not sure that the $(MKDIR) -p is working for every system.

I try install r.learn.ml2 on MS Windows, and I get error:

C:\Users\IEUser>g.extension r.learn.ml2
Downloading precompiled GRASS Addons <r.learn.ml2>...
Fetching <r.learn.ml2> from
<http://wingrass.fsv.cvut.cz/grass79/x86_64/addons/grass-7.9.dev/r.learn.ml2.zip>
(be patient)...
Updating extensions metadata file...
Updating extension modules metadata file...
WARNING: No metadata available for module 'transformers'.
WARNING: No metadata available for module 'stats'.
WARNING: No metadata available for module 'r.learn.predict'.
WARNING: No metadata available for module 'indexing'.
WARNING: No metadata available for module 'r.learn.train'.
WARNING: No metadata available for module 'raster'.
WARNING: No metadata available for module 'utils'.
ERROR: Unable to read manual page: [Errno 2] No such file or directory:
       'C:\\Users\\IEUser\\AppData\\Roaming\\GRASS7\\addons\\docs\\html\\transformers.html'

r.learn.ml2 Add-On installation dir structure (rlearnlib) seems alright:

[tmszi]

You missed the creation of 'rlearnlib' dir in the Makefile, check my commit.