r.centroids #396
Merged
r.centroids #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenzeslaus
requested changes
Jan 9, 2021
There was a problem hiding this comment.
This looks great and it has a potential to be quite useful. I like how short it is.
Well, it is so short that I didn't have much to say, but I did some nit-picking.
You can also run flake8, pylint, and black on it. It will flag things such as #% which you can't do anything about right now, but it will further polish the code.
petrasovaa
reviewed
Jan 9, 2021
Co-authored-by: Anna Petrasova <kratochanna@gmail.com>
…into r-centroids
neteler
reviewed
Jan 24, 2021
neteler
reviewed
Jan 24, 2021
neteler
reviewed
Jan 24, 2021
neteler
reviewed
Jan 24, 2021
neteler
reviewed
Jan 24, 2021
Co-authored-by: Markus Neteler <neteler@osgeo.org>
Co-authored-by: Markus Neteler <neteler@osgeo.org>
Co-authored-by: Markus Neteler <neteler@osgeo.org>
Co-authored-by: Markus Neteler <neteler@osgeo.org>
Changed to match naming convention.
wenzeslaus
requested changes
Feb 9, 2021
wenzeslaus
approved these changes
Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added r.centroids, a wrapper module for r.volume that computes centroids from clumps of data as a raster.