Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation of addon manuals for Windows #524

Merged
merged 21 commits into from
Jun 24, 2021

Conversation

ninsbl
Copy link
Member

@ninsbl ninsbl commented May 6, 2021

I changed several addons in order to make manual pages compile.
See compilation log here:
https://wingrass.fsv.cvut.cz/grass78/x86_64/addons/latest/logs/

Addons containing serval modules can have failed even though the log says differently... Would be great if you could check the addon you contributed to...

@ninsbl ninsbl added the Windows MS Windows specific label May 6, 2021
@neteler
Copy link
Member

neteler commented May 11, 2021

May this be merged?

@neteler
Copy link
Member

neteler commented May 16, 2021

This PR needs some rework concerning

grass7/imagery/i.sentinel/i.sentinel.download/i.sentinel.download.py

In essence, this is missing (in the right position):

try:
    from tqdm import tqdm
except ImportError as e:
    gs.fatal(_("Module requires tqdm library: {}").format(e))

I tried to locally fix it and push to this PR but failed (not enough git skills). @ninsbl can you pls take a look?

@neteler
Copy link
Member

neteler commented Jun 13, 2021

Gentle ping, @ninsbl - would you mind to rebase this PR (see above)?

@ninsbl
Copy link
Member Author

ninsbl commented Jun 24, 2021

@neteler OK to merge?

Copy link
Member

@neteler neteler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ninsbl ninsbl merged commit 54010b4 into OSGeo:master Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Windows MS Windows specific
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants