GitHub actions: update to current versions

[neteler]

The GHA ci.yml and others show the warning

Node.js 12 actions are deprecated. Please update the following actions to use Node.js 16: actions/checkout@v2, actions/setup-python@v2, r-lib/actions/setup-r@v1, actions/upload-artifact@v2. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.

Additionally:

• update the various actions
• updates ubuntu-20.04 to ubuntu-22.04 (see also CI: switch to ubuntu-22.04 image to avoid timeout grass#2730)
• sync Python to v3.10
• updates to super-linter:v4
• super-linter: enable markdown linting
• use the real super-linter action instead of a container
• super-linter.yml: do not mix VALIDATE=true and VALIDATE=false

[neteler]

The Super-linter is yet unhappy, ideas?

2023-01-18 12:55:17 [INFO]   Gathering user validation information...
2023-01-18 12:55:17 [INFO]   - Validating ALL files in code base...
2023-01-18 12:55:17 [FATAL]   Behavior not supported, please either only include (VALIDATE=true) or exclude (VALIDATE=false) linters, but not both

[nilason]

Did a quick look at https://github.com/github/super-linter, but haven't been able to pinpoint exactly what needs to be changed yet.

GRASS core is still using super-linter:v2.2.2:

https://github.com/OSGeo/grass/blob/cb8293e8d40c02857b3a15bac441f703339ba5fd/.github/workflows/super-linter.yml#L22

[nilason]

Perhaps upgrading super-linter could be subject for a separate PR. The other changes looks good to me.

[echoix]

For the lines under,

          VALIDATE_BASH: false
          VALIDATE_CSS: false
          VALIDATE_DOCKER: false
          VALIDATE_JAVASCRIPT_ES: true
          VALIDATE_JAVASCRIPT_STANDARD: false
          VALIDATE_JSON: true
          VALIDATE_MD: true
          VALIDATE_PERL: false
          VALIDATE_POWERSHELL: true
          VALIDATE_XML: false
          VALIDATE_YAML: true

If I remember well super-linter, once either one linter is enabled or disabled, it won't run all the linters by default. You must manually list all the ones you want activated if you include one VALIDATE_<a language>: true.
Edit: see https://github.com/marketplace/actions/super-linter#environment-variables, which tells the same thing

So, if only the ones you want to run are the ones that are true currently true, we can comment out the false ones:

          # VALIDATE_BASH: false
          # VALIDATE_CSS: false
          # VALIDATE_DOCKER: false
          VALIDATE_JAVASCRIPT_ES: true
          # VALIDATE_JAVASCRIPT_STANDARD: false
          VALIDATE_JSON: true
          VALIDATE_MD: true
          # VALIDATE_PERL: false
          VALIDATE_POWERSHELL: true
          # VALIDATE_XML: false
          VALIDATE_YAML: true

I don't think disabling Docker is still useful though, we do have some Dockerfiles.

[nilason]

So, if only the ones you want to run are the ones that are true currently true, we can comment out the false ones:

          # VALIDATE_BASH: false
          # VALIDATE_CSS: false
          # VALIDATE_DOCKER: false
          VALIDATE_JAVASCRIPT_ES: true
          # VALIDATE_JAVASCRIPT_STANDARD: false
          VALIDATE_JSON: true
          VALIDATE_MD: true
          # VALIDATE_PERL: false
          VALIDATE_POWERSHELL: true
          # VALIDATE_XML: false
          VALIDATE_YAML: true

Worth a try!

I don't think disabling Docker is still useful though, we do have some Dockerfiles.

In "addons"?

[echoix]

In "addons"?

Oh, I forgot that it was this repo.

[neteler]

Thanks for your suggestions.
I have now commented out the entries set to false super-linter.yml (cb87c31).
If that fails, too, I'll go back to the original superlinter version (then updates may go into a separate PR).

[neteler]

So, if only the ones you want to run are the ones that are true currently true, we can comment out the false ones

Thanks @echoix, your super-linter.yml change suggestion worked!

[nilason]

Nice!

[neteler]

This now fails with markdown errors :D (so, the runner works).

[nilason]

This now fails with markdown errors :D (so, the runner works).

I'm working on a linting fix for markdown files...