libgrass_imagery: missing SONAME #2268

t0b3 · 2022-03-18T10:48:47Z

bisecting revealed since introduction of this line

Line 10 in 98dba90

include $(MODULE_TOPDIR)/include/Make/Grass.make

by 0e109f6 the library libgrass_imagery.8.0.so has no SONAME anymore.

i.e. objdump -p ./dist.x86_64-pc-linux-gnu/lib/libgrass_imagery.8.0.so | grep SONAME should not be empty but something like SONAME libgrass_imagery.8.0.so

this missing SONAME leads to

downstream issues like [RPM] Backport a downstream spec fix for GRASS' libgrass_imagery qgis/QGIS#47576 and
workarounds https://src.fedoraproject.org/rpms/qgis/c/115e2008ceee0ebcba88dcbe8580eca514f6f08d?branch=rawhide

thanks for reworking this Makefile 😄

The text was updated successfully, but these errors were encountered:

t0b3 · 2022-03-18T10:51:59Z

@marisn @veroandreo any idea how to improve this situation?

Fixes OSGeo#2268

* Update lib/imagery/Makefile: fix SONAME missing Fixes #2268 Co-authored-by: Nicklas Larsson <n_larsson@yahoo.com>

The change implemented in #2269 actually didn't fix the SONAME problem (see issue #2268), at least on Fedora: ``` # status after PR 2269: readelf -d /usr/lib64/grass80/lib/libgrass_imagery.so Dynamic section at offset 0x16860 contains 31 entries: Tag Type Name/Value 0x0000000000000001 (NEEDED) Shared library: [libgrass_gis.8.0.so] 0x0000000000000001 (NEEDED) Shared library: [libm.so.6] 0x0000000000000001 (NEEDED) Shared library: [libgrass_raster.8.0.so] 0x0000000000000001 (NEEDED) Shared library: [libgrass_vector.8.0.so] 0x0000000000000001 (NEEDED) Shared library: [libc.so.6] 0x000000000000001d (RUNPATH) Library runpath: [/usr/lib64/grass80/lib] 0x000000000000000c (INIT) 0x5000 0x000000000000000d (FINI) 0x11e8c 0x0000000000000019 (INIT_ARRAY) 0x17848 ... ``` ==> The SONAME is still missing which means that #2269 did not solve it (tested on Fedora). With this PR (see e.g. also `lib/display/Makefile`) the SONAME appears: ``` readelf -d /home/mneteler/software/grass80/dist.x86_64-pc-linux-gnu/lib/libgrass_imagery.so Dynamic section at offset 0x14db8 contains 30 entries: Tag Type Name/Value 0x0000000000000001 (NEEDED) Shared library: [libgrass_gis.8.0.so] 0x0000000000000001 (NEEDED) Shared library: [libm.so.6] 0x0000000000000001 (NEEDED) Shared library: [libgrass_raster.8.0.so] 0x0000000000000001 (NEEDED) Shared library: [libgrass_vector.8.0.so] 0x0000000000000001 (NEEDED) Shared library: [libc.so.6] 0x000000000000000e (SONAME) Library soname: [libgrass_imagery.8.0.so] 0x000000000000001d (RUNPATH) Library runpath: [/usr/local/grass80/lib] 0x000000000000000c (INIT) 0x5000 0x000000000000000d (FINI) 0x10864 0x0000000000000019 (INIT_ARRAY) 0x15da0 ... ``` which is a requirement to compile, install and run the GDAL-GRASS driver (https://github.com/OSGeo/gdal-grass).

* Update lib/imagery/Makefile: fix SONAME missing Fixes OSGeo#2268 Co-authored-by: Nicklas Larsson <n_larsson@yahoo.com>

The change implemented in OSGeo#2269 actually didn't fix the SONAME problem (see issue OSGeo#2268), at least on Fedora: ``` # status after PR 2269: readelf -d /usr/lib64/grass80/lib/libgrass_imagery.so Dynamic section at offset 0x16860 contains 31 entries: Tag Type Name/Value 0x0000000000000001 (NEEDED) Shared library: [libgrass_gis.8.0.so] 0x0000000000000001 (NEEDED) Shared library: [libm.so.6] 0x0000000000000001 (NEEDED) Shared library: [libgrass_raster.8.0.so] 0x0000000000000001 (NEEDED) Shared library: [libgrass_vector.8.0.so] 0x0000000000000001 (NEEDED) Shared library: [libc.so.6] 0x000000000000001d (RUNPATH) Library runpath: [/usr/lib64/grass80/lib] 0x000000000000000c (INIT) 0x5000 0x000000000000000d (FINI) 0x11e8c 0x0000000000000019 (INIT_ARRAY) 0x17848 ... ``` ==> The SONAME is still missing which means that OSGeo#2269 did not solve it (tested on Fedora). With this PR (see e.g. also `lib/display/Makefile`) the SONAME appears: ``` readelf -d /home/mneteler/software/grass80/dist.x86_64-pc-linux-gnu/lib/libgrass_imagery.so Dynamic section at offset 0x14db8 contains 30 entries: Tag Type Name/Value 0x0000000000000001 (NEEDED) Shared library: [libgrass_gis.8.0.so] 0x0000000000000001 (NEEDED) Shared library: [libm.so.6] 0x0000000000000001 (NEEDED) Shared library: [libgrass_raster.8.0.so] 0x0000000000000001 (NEEDED) Shared library: [libgrass_vector.8.0.so] 0x0000000000000001 (NEEDED) Shared library: [libc.so.6] 0x000000000000000e (SONAME) Library soname: [libgrass_imagery.8.0.so] 0x000000000000001d (RUNPATH) Library runpath: [/usr/local/grass80/lib] 0x000000000000000c (INIT) 0x5000 0x000000000000000d (FINI) 0x10864 0x0000000000000019 (INIT_ARRAY) 0x15da0 ... ``` which is a requirement to compile, install and run the GDAL-GRASS driver (https://github.com/OSGeo/gdal-grass).

* Update lib/imagery/Makefile: fix SONAME missing Fixes OSGeo#2268 Co-authored-by: Nicklas Larsson <n_larsson@yahoo.com>

The change implemented in OSGeo#2269 actually didn't fix the SONAME problem (see issue OSGeo#2268), at least on Fedora: ``` # status after PR 2269: readelf -d /usr/lib64/grass80/lib/libgrass_imagery.so Dynamic section at offset 0x16860 contains 31 entries: Tag Type Name/Value 0x0000000000000001 (NEEDED) Shared library: [libgrass_gis.8.0.so] 0x0000000000000001 (NEEDED) Shared library: [libm.so.6] 0x0000000000000001 (NEEDED) Shared library: [libgrass_raster.8.0.so] 0x0000000000000001 (NEEDED) Shared library: [libgrass_vector.8.0.so] 0x0000000000000001 (NEEDED) Shared library: [libc.so.6] 0x000000000000001d (RUNPATH) Library runpath: [/usr/lib64/grass80/lib] 0x000000000000000c (INIT) 0x5000 0x000000000000000d (FINI) 0x11e8c 0x0000000000000019 (INIT_ARRAY) 0x17848 ... ``` ==> The SONAME is still missing which means that OSGeo#2269 did not solve it (tested on Fedora). With this PR (see e.g. also `lib/display/Makefile`) the SONAME appears: ``` readelf -d /home/mneteler/software/grass80/dist.x86_64-pc-linux-gnu/lib/libgrass_imagery.so Dynamic section at offset 0x14db8 contains 30 entries: Tag Type Name/Value 0x0000000000000001 (NEEDED) Shared library: [libgrass_gis.8.0.so] 0x0000000000000001 (NEEDED) Shared library: [libm.so.6] 0x0000000000000001 (NEEDED) Shared library: [libgrass_raster.8.0.so] 0x0000000000000001 (NEEDED) Shared library: [libgrass_vector.8.0.so] 0x0000000000000001 (NEEDED) Shared library: [libc.so.6] 0x000000000000000e (SONAME) Library soname: [libgrass_imagery.8.0.so] 0x000000000000001d (RUNPATH) Library runpath: [/usr/local/grass80/lib] 0x000000000000000c (INIT) 0x5000 0x000000000000000d (FINI) 0x10864 0x0000000000000019 (INIT_ARRAY) 0x15da0 ... ``` which is a requirement to compile, install and run the GDAL-GRASS driver (https://github.com/OSGeo/gdal-grass).

* Update lib/imagery/Makefile: fix SONAME missing Fixes OSGeo#2268 Co-authored-by: Nicklas Larsson <n_larsson@yahoo.com>

The change implemented in OSGeo#2269 actually didn't fix the SONAME problem (see issue OSGeo#2268), at least on Fedora: ``` # status after PR 2269: readelf -d /usr/lib64/grass80/lib/libgrass_imagery.so Dynamic section at offset 0x16860 contains 31 entries: Tag Type Name/Value 0x0000000000000001 (NEEDED) Shared library: [libgrass_gis.8.0.so] 0x0000000000000001 (NEEDED) Shared library: [libm.so.6] 0x0000000000000001 (NEEDED) Shared library: [libgrass_raster.8.0.so] 0x0000000000000001 (NEEDED) Shared library: [libgrass_vector.8.0.so] 0x0000000000000001 (NEEDED) Shared library: [libc.so.6] 0x000000000000001d (RUNPATH) Library runpath: [/usr/lib64/grass80/lib] 0x000000000000000c (INIT) 0x5000 0x000000000000000d (FINI) 0x11e8c 0x0000000000000019 (INIT_ARRAY) 0x17848 ... ``` ==> The SONAME is still missing which means that OSGeo#2269 did not solve it (tested on Fedora). With this PR (see e.g. also `lib/display/Makefile`) the SONAME appears: ``` readelf -d /home/mneteler/software/grass80/dist.x86_64-pc-linux-gnu/lib/libgrass_imagery.so Dynamic section at offset 0x14db8 contains 30 entries: Tag Type Name/Value 0x0000000000000001 (NEEDED) Shared library: [libgrass_gis.8.0.so] 0x0000000000000001 (NEEDED) Shared library: [libm.so.6] 0x0000000000000001 (NEEDED) Shared library: [libgrass_raster.8.0.so] 0x0000000000000001 (NEEDED) Shared library: [libgrass_vector.8.0.so] 0x0000000000000001 (NEEDED) Shared library: [libc.so.6] 0x000000000000000e (SONAME) Library soname: [libgrass_imagery.8.0.so] 0x000000000000001d (RUNPATH) Library runpath: [/usr/local/grass80/lib] 0x000000000000000c (INIT) 0x5000 0x000000000000000d (FINI) 0x10864 0x0000000000000019 (INIT_ARRAY) 0x15da0 ... ``` which is a requirement to compile, install and run the GDAL-GRASS driver (https://github.com/OSGeo/gdal-grass).

t0b3 added a commit to t0b3/grass that referenced this issue Mar 18, 2022

fix: SONAME missing

53e4600

Fixes OSGeo#2268

t0b3 mentioned this issue Mar 18, 2022

lib/imagery: fix SONAME missing #2269

Merged

nilason added the bug Something isn't working label Mar 18, 2022

t0b3 added a commit to t0b3/grass that referenced this issue Mar 18, 2022

fix: SONAME missing

b9bfb08

Fixes OSGeo#2268

t0b3 mentioned this issue Mar 20, 2022

add GRASS8 to build tests qgis/QGIS#47887

Merged

neteler closed this as completed in #2269 Mar 23, 2022

neteler pushed a commit that referenced this issue Mar 23, 2022

lib/imagery: fix SONAME missing (#2269)

7573a7c

* Update lib/imagery/Makefile: fix SONAME missing Fixes #2268 Co-authored-by: Nicklas Larsson <n_larsson@yahoo.com>

neteler pushed a commit that referenced this issue Mar 23, 2022

lib/imagery: fix SONAME missing (#2269)

1645abd

* Update lib/imagery/Makefile: fix SONAME missing Fixes #2268 Co-authored-by: Nicklas Larsson <n_larsson@yahoo.com>

neteler mentioned this issue May 8, 2022

lib/imagery: fix missing SONAME #2363

Merged

ninsbl pushed a commit to ninsbl/grass that referenced this issue Oct 26, 2022

lib/imagery: fix SONAME missing (OSGeo#2269)

6fe2704

* Update lib/imagery/Makefile: fix SONAME missing Fixes OSGeo#2268 Co-authored-by: Nicklas Larsson <n_larsson@yahoo.com>

ninsbl pushed a commit to ninsbl/grass that referenced this issue Feb 17, 2023

lib/imagery: fix SONAME missing (OSGeo#2269)

3708781

* Update lib/imagery/Makefile: fix SONAME missing Fixes OSGeo#2268 Co-authored-by: Nicklas Larsson <n_larsson@yahoo.com>

neteler pushed a commit to nilason/grass that referenced this issue Nov 7, 2023

lib/imagery: fix SONAME missing (OSGeo#2269)

f09833b

* Update lib/imagery/Makefile: fix SONAME missing Fixes OSGeo#2268 Co-authored-by: Nicklas Larsson <n_larsson@yahoo.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

libgrass_imagery: missing SONAME #2268

libgrass_imagery: missing SONAME #2268

t0b3 commented Mar 18, 2022

t0b3 commented Mar 18, 2022

libgrass_imagery: missing SONAME #2268

libgrass_imagery: missing SONAME #2268

Comments

t0b3 commented Mar 18, 2022

t0b3 commented Mar 18, 2022