Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RPM] Backport a downstream spec fix for GRASS' libgrass_imagery #47576

Closed
wants to merge 1 commit into from

Conversation

daniviga
Copy link
Contributor

@daniviga daniviga commented Feb 28, 2022

Description

Include a downstream fix from @manisandro for picking up the right path of libgrass_imagery from GRASS8: https://src.fedoraproject.org/rpms/qgis/blob/rawhide/f/qgis.spec#_185

# FIXME
# No idea why libgrass_imagery appears as -lgrass_imagery and not as %%{_libdir}/grass/lib/libgrass_imagery.8.0.so
# like all other grass libs... But it results in a Requires on libgrass_imagery.so rather than libgrass_imagery.8.0.so	
# and the former is not provided by grass-libs, hence results in broken dependencies...

Regression log: dnf_install_b97193e7d9.txt

I will also work in the next days to sync our upstream with downstream as much as possible.

Needs backport to release-3_22 and release-3_24

@github-actions github-actions bot added this to the 3.26.0 milestone Feb 28, 2022
@daniviga daniviga changed the title [RPM] Backport a downstream spec fix for GRASS's libgrass_imagery [RPM] Backport a downstream spec fix for GRASS' libgrass_imagery Feb 28, 2022
@manisandro
Copy link
Member

More than a fix this is a ugly workaround... Would be interesting to understand what's actually going on here, if it's a cmake bug or an issue with how grass creates the library, though as far as I could see there really is nothing wrong with the libraries.

@daniviga
Copy link
Contributor Author

daniviga commented Mar 1, 2022

I also started looking at it, however it works fine with GRASS7 so, it seems more a GRASS8 regression to me.

Maybe @neteler has an idea?

@neteler
Copy link
Contributor

neteler commented Mar 1, 2022

I have recently compiled GRASS GIS 8.0.1 on Fedora Koji and the RPM files look all normal. Example:

https://kojipkgs.fedoraproject.org//packages/grass/8.0.1/1.fc36/data/logs/x86_64/build.log

...
extracting debug info from /builddir/build/BUILDROOT/grass-8.0.1-1.fc36.x86_64/usr/lib64/grass80/lib/libgrass_gproj.8.0.so
extracting debug info from /builddir/build/BUILDROOT/grass-8.0.1-1.fc36.x86_64/usr/lib64/grass80/lib/libgrass_htmldriver.8.0.so
extracting debug info from /builddir/build/BUILDROOT/grass-8.0.1-1.fc36.x86_64/usr/lib64/grass80/lib/libgrass_imagery.8.0.so     <<== !
extracting debug info from /builddir/build/BUILDROOT/grass-8.0.1-1.fc36.x86_64/usr/lib64/grass80/lib/libgrass_interpdata.8.0.so
extracting debug info from /builddir/build/BUILDROOT/grass-8.0.1-1.fc36.x86_64/usr/lib64/grass80/lib/libgrass_interpfl.8.0.so
...

@github-actions
Copy link

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in a week.

@github-actions github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Mar 16, 2022
@github-actions
Copy link

While we hate to see this happen, this PR has been automatically closed because it has not had any activity in the last 21 days. If this pull request should be reconsidered, please follow the guidelines in the previous comment and reopen this pull request. Or, if you have any further questions, just ask! We love to help, and if there's anything the QGIS project can do to help push this PR forward please let us know how we can assist.

@github-actions github-actions bot closed this Mar 23, 2022
@neteler
Copy link
Contributor

neteler commented Mar 23, 2022

@nilason do you have an idea here by chance?

@nilason
Copy link
Contributor

nilason commented Mar 23, 2022

By the look of it OSGeo/grass#2269 should fix this.

@github-actions github-actions bot removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Mar 23, 2022
@neteler
Copy link
Contributor

neteler commented Mar 23, 2022

@daniviga @manisandro
This PR has been merged and backported (upcoming GRASS GIS 8.0.2): OSGeo/grass#2269

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants