Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wxGUI/g.gui.psmap: fix move line object error message #1031

Merged
merged 1 commit into from
Oct 22, 2020
Merged

wxGUI/g.gui.psmap: fix move line object error message #1031

merged 1 commit into from
Oct 22, 2020

Conversation

tmszi
Copy link
Member

@tmszi tmszi commented Oct 19, 2020 •
edited
Loading

To Reproduce:

  1. Launch Cartographic Composer g.gui.psmap
  2. Choose Add simple graphics tool - Line from toolbar
  3. Draw line
  4. Move line with Pointer tool

Error message:

Traceback (most recent call last):
  File "/usr/lib64/grass79/gui/wxpython/psmap/frame.py", line 1493, in MouseActions
    self.OnLeftUp(event)
  File "/usr/lib64/grass79/gui/wxpython/psmap/frame.py", line 1720, in OnLeftUp
    self.RecalculatePosition(ids=[self.dragId])
  File "/usr/lib64/grass79/gui/wxpython/psmap/frame.py", line 1999, in RecalculatePosition
    xDiff, yDiff) + self.instruction[id]['where'][0]
TypeError: unsupported operand type(s) for +: 'Point2D' and 'tuple'

@tmszi tmszi added bug Something isn't working GUI wxGUI related labels Oct 19, 2020
petrasovaa
petrasovaa requested changes Oct 20, 2020
View reviewed changes
gui/wxpython/psmap/frame.py Outdated Show resolved Hide resolved
@tmszi @petrasovaa
wxGUI/g.gui.psmap: fix move line object error message
eaf6a56 
Co-authored-by: Anna Petrasova <kratochanna@gmail.com>
@tmszi tmszi force-pushed the fix-g-gui-psmap-move-line-error branch from b66ff5d to eaf6a56 Compare October 20, 2020 07:01
@tmszi tmszi requested a review from petrasovaa October 20, 2020 07:03
@petrasovaa petrasovaa merged commit 8ca5c48 into OSGeo:master Oct 22, 2020
neteler pushed a commit that referenced this pull request Oct 22, 2020
@tmszi @neteler
wxGUI/g.gui.psmap: fix move line object error message (#1031)
a090b3a
@neteler neteler added this to the 7.8.5 milestone Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrasovaa petrasovaa petrasovaa approved these changes

Assignees
No one assigned
Labels
bug Something isn't working GUI wxGUI related
Projects
None yet
Milestone
7.8.5
Development

Successfully merging this pull request may close these issues.
3 participants
@tmszi @petrasovaa @neteler