t.vect.export: GPKG support added #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With this method, each vector will be exported into a separate GPKG. Why not exporting all vectors of a single stvds into a single GPKG with |
|
That sounds reasonable. But I wouldn't know how to rewrite _export_vector_maps_as_gpkg() accordingly... |
|
In this case the importer must be aware of this format too. Hence, more
programming effort to get it to work. The current solution is fine in my
opinion.
Am Do., 12. Sept. 2019 um 14:56 Uhr schrieb Markus Metz <
notifications@github.com>:
… With this method, each vector will be exported into a separate GPKG. Why
not exporting all vectors of a single stvds into a single GPKG with v.out.ogr
-u?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#129?email_source=notifications&email_token=ACQPJDJVOIR42EVFNRPW3VTQJI4ALA5CNFSM4IWB6JO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6RY4BY#issuecomment-530812423>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACQPJDOWC465KVE4O6KLVHDQJI4ALANCNFSM4IWB6JOQ>
.
|
|
Can I merge or not yet? |
|
I agree with @huhabla that the current solution is fine. Putting all vectors into a single OGR datasource can make things more complicated. Fine with me to merge. |
|
Backported to relbr78 in 04b2790 |
petrasovaa
pushed a commit
to petrasovaa/grass
that referenced
this pull request
Dec 3, 2019
landam
pushed a commit
to landam/grass
that referenced
this pull request
Jan 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.