Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wxGUI/vdigit: fix close settings dialog (if no vector map has been selected) #1394

Merged
merged 1 commit into from
Jun 18, 2021

Conversation

tmszi
Copy link
Member

@tmszi tmszi commented Feb 21, 2021

To Reproduce
Steps to reproduce the behavior:

  1. Launch wxGUI
  2. Display some vector map e.g. 'railroads'
  3. Launch Vector digitizer, 2D view -> Vector digitizer, and choose 'railroads' vector map
  4. Quit vector digitizer (click on the Quit toolbar tool)
  5. Launch Vector digitizer again, but don't choose 'railroads' vector map
  6. Launch Vector digitizer settings dialog (gear wheel icon on the vector digitizer toolbar tool)
  7. Hit close button on the vector digitizer settings dialog
  8. See error

Error message

Traceback (most recent call last):
  File "/usr/lib64/grass79/gui/wxpython/mapwin/buffered.py",
line 605, in OnPaint

self.pdcVector.DrawToDCClipped(gcdc, rgn)
AttributeError
:
'NoneType' object has no attribute 'DrawToDCClipped'
Traceback (most recent call last):
  File "/usr/lib64/grass79/gui/wxpython/mapwin/buffered.py",
line 605, in OnPaint

self.pdcVector.DrawToDCClipped(gcdc, rgn)
AttributeError
:
'NoneType' object has no attribute 'DrawToDCClipped'

@tmszi tmszi added bug Something isn't working GUI wxGUI related labels Feb 21, 2021
If no vector map has been selected.
@tmszi tmszi force-pushed the wx_vdigit-fix-close-settings-dialog branch from 9218316 to ee9ded3 Compare June 18, 2021 04:16
@tmszi tmszi merged commit 9377fec into OSGeo:master Jun 18, 2021
@tmszi tmszi deleted the wx_vdigit-fix-close-settings-dialog branch June 18, 2021 05:15
HuidaeCho pushed a commit to HuidaeCho/grass that referenced this pull request Jun 19, 2021
If no vector map has been selected.
@neteler neteler added this to the 8.0.0 milestone Dec 9, 2021
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Oct 26, 2022
If no vector map has been selected.
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Feb 17, 2023
If no vector map has been selected.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working GUI wxGUI related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants