Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #3882 #161

Merged
merged 3 commits into from
Oct 27, 2019
Merged

fix #3882 #161

merged 3 commits into from
Oct 27, 2019

Conversation

petrasovaa
Copy link
Contributor

@petrasovaa petrasovaa commented Oct 24, 2019

wxGUI: g.pnmcomp needs to use the same size as the indivually rendered maps

@hellik hellik self-requested a review October 24, 2019 08:26
@petrasovaa petrasovaa changed the title wxGUI: g.pnmcomp needs to use the same size as the indivually rendere… fix #3882 Oct 25, 2019
@petrasovaa
Copy link
Contributor Author

I only catch the weird exception, it seems to be working otherwise. I couldn't find a proper solution to this.

@hellik
Copy link
Member

hellik commented Oct 25, 2019

tested it with a self compiled

System Info                                                                     
GRASS Version: 7.8.1dev                                                         
Code revision: 4785a5b77                                                        
Build date: 2019-10-25                                                          
Build platform: x86_64-w64-mingw32                                              
GDAL: 2.4.1                                                                     
PROJ: 5.2.0                                                                     
GEOS: 3.8.0                                                                     
SQLite: 3.29.0                                                                  
Python: 3.7.0                                                                   
wxPython: 4.0.3                                                                 
Platform: Windows-10-10.0.18362-SP0 (OSGeo4W) 
GRASS Version: 7.8.1dev                                                         
Code revision: 4785a5b77 

is now also availabe in OSGeo4W (without patch of #161 )

applied changes of #161

Traceback (most recent call last):
  File "C:\OSGEO4~1\apps\grass\grass78\gui\wxpython\vdigit\t
oolbars.py", line 391, in OnAddAreaTool

self.OnAddArea(event)
  File "C:\OSGEO4~1\apps\grass\grass78\gui\wxpython\vdigit\t
oolbars.py", line 369, in OnAddArea

self.addArea, self.icons['addArea'].GetBitmap())
TypeError
:
ToolBar.SetToolNormalBitmap(): argument 2 has unexpected
type 'NoneType'

@petrasovaa
Copy link
Contributor Author

I found the problem (should have paid more attention to the error message). I disabled the setlocale code for windows (there doesn't seem to be any problem on linux), but I suspect there was a reason the code was there, so it needs to be tested... Specifically, the problem comes up if you switch to 3D view or digitizer.

Copy link
Member

@hellik hellik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with the changes in core/render.py, nviz/wxniz.py and vdigit/wxdisplay, vector digitzing of points, lines and areas works again.

@hellik hellik added backport_needed windows Microsoft Windows specific bug Something isn't working labels Oct 26, 2019
@petrasovaa petrasovaa merged commit f43825b into OSGeo:master Oct 27, 2019
@petrasovaa petrasovaa deleted the fix-3882 branch October 27, 2019 02:12
@neteler neteler added this to the 7.8.1 milestone Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working windows Microsoft Windows specific
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants