Fix failing vector digitizer on mac, trac#3487

[nilason]

This fixes the trac#3487 issue with failing (segfault) vector digitizing on mac.

It is actually a fix for two independent issues:

1. ctypes related. Ctypesgen generates incomplete py files. Addressed by adding compiler flag.
2. render related. On mac a render cycle has already started when the toolbar is inserted. Addressed by temporarily suspend rendering.

The second fix affects all platforms, so should be tested on linux and windows.

Important fix, should be backported to 7.8.3 if accepted.

Update: the second issue was reported separately: trac#3652.
The issue trac#3472 is probably also addressed by the ctypesgen fix.

Update 2: the second issue, was probably caused by my personally built debug version of python. Reverting to standard python build, this is no longer an issue. The trac#3652 doesn't seem to be an issue anymore.

[petrasovaa]

Thanks for looking into this. While I can't comment on the ctypes issue and I am ok with merging that, I think the other issue with rendering could be solved in better way. I can't replicate it on Linux, is the error exactly the same as in trac#3652? There has been a fix for this since then in #161, so I just want to make sure your traceback is the same. I think what's needed is to pass the original environment (determining the rendering size) correctly to OnRenderDone in render.py, so all rendering uses the same size.

[nilason]

Thanks for bringing the second issue up. After testing with standard python I removed that part of the PR. See updated comment above.
For my part this is now good to go.

[cmbarton]

I'm checking to see if this goes directly to Nilason for an offline question. Michael

…

____________________ C. Michael Barton Director, Center for Social Dynamics & Complexity Professor of Anthropology, School of Human Evolution & Social Change Head, Graduate Faculty in Complex Adaptive Systems Science Arizona State University voice: 480-965-6262 (SHESC), 480-965-8130/727-9746 (CSDC) fax: 480-965-7671 (SHESC), 480-727-0709 (CSDC) www: http://www.public.asu.edu/~cmbarton, https://complexity.asu.edu/csdc On Mar 25, 2020, at 12:27 AM, nilason <notifications@github.com<mailto:notifications@github.com>> wrote: Thanks for bringing the second issue up. After testing with standard python I removed that part of the PR. See updated comment above. For my part this is now god to go. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub<#456 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ACENLL64AA6LD5LKDGDIDTLRJGW6BANCNFSM4LSSWD5Q>.

[nilason]

Thanks! To the best of my knowledge, this was the last critical fix (but one: #408) for mac specific bugs.