Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r.clump: fix clumping of FCELL/DCELL maps with threshold=0 #1792

Merged
merged 1 commit into from Jan 12, 2022

Conversation

metzm
Copy link
Contributor

@metzm metzm commented Aug 13, 2021

With threshold=0, FCELL/DCELL maps are truncated to CELL, resulting in clumps of input cells with different values. Fixes #1599.

@metzm metzm added bug Something isn't working backport_needed raster Related to raster data processing labels Aug 13, 2021
@metzm metzm added this to the 8.0.0 milestone Aug 13, 2021
fix clumping of FCELL/DCELL maps with threshold=0
@mlennert
Copy link
Contributor

mlennert commented Oct 2, 2021

@metzm Can this be merged ?

@neteler
Copy link
Member

neteler commented Dec 2, 2021

@ecodiv Do you see a chance to test this bugfix which addresses your issue?

Copy link
Member

@wenzeslaus wenzeslaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would appreciate an addition to documentation with what is basically the PR description, i.e., what to expect as a result, but the change seems correct in the context.

@neteler neteler merged commit 4d1496e into OSGeo:main Jan 12, 2022
neteler pushed a commit that referenced this pull request Jan 12, 2022
With threshold=0, FCELL/DCELL maps are truncated to CELL, resulting in clumps of input cells with different values. Fixes #1599.
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Oct 26, 2022
With threshold=0, FCELL/DCELL maps are truncated to CELL, resulting in clumps of input cells with different values. Fixes OSGeo#1599.
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Feb 17, 2023
With threshold=0, FCELL/DCELL maps are truncated to CELL, resulting in clumps of input cells with different values. Fixes OSGeo#1599.
neteler pushed a commit to nilason/grass that referenced this pull request Nov 7, 2023
With threshold=0, FCELL/DCELL maps are truncated to CELL, resulting in clumps of input cells with different values. Fixes OSGeo#1599.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working raster Related to raster data processing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

r.clump clumps cells that do not have the same cell values
5 participants