Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r.clump clumps cells that do not have the same cell values #1599

Closed
ecodiv opened this issue May 27, 2021 · 0 comments · Fixed by #1792
Closed

r.clump clumps cells that do not have the same cell values #1599

ecodiv opened this issue May 27, 2021 · 0 comments · Fixed by #1792
Labels
bug Something isn't working
Milestone
8.0.0

Comments

@ecodiv
Copy link
Contributor

ecodiv commented May 27, 2021

Describe the bug

Running r.clump on a floating raster with gradually changing values, and with threshold value set to 0 (default). The result is a a map with clusters consisting of raster cells that do not have the same values. Likely cause, r.clump currently converts a floating point raster to integer first.

To Reproduce
Steps to reproduce the behavior:

r.random.surface output=test high=100
r.mapcalc "test2 = test/1000.0"
r.clump -d input=test2 output=test3

Expected behavior
Only contiguous cells with the same cell values receive the same category (clump) value

System description (please complete the following information):

  • Operating System: Windows 10
  • GRASS GIS version [e.g. 7.8.5]
@ecodiv ecodiv added the bug Something isn't working label May 27, 2021
@metzm metzm mentioned this issue Aug 13, 2021
Merged
neteler pushed a commit that referenced this issue Jan 12, 2022
@metzm
r.clump (#1792)
4d1496e 
With threshold=0, FCELL/DCELL maps are truncated to CELL, resulting in clumps of input cells with different values. Fixes #1599.
neteler pushed a commit that referenced this issue Jan 12, 2022
@metzm @neteler
r.clump (#1792)
00870f9 
With threshold=0, FCELL/DCELL maps are truncated to CELL, resulting in clumps of input cells with different values. Fixes #1599.
@neteler neteler added this to the 8.0.0 milestone Jan 12, 2022
ninsbl pushed a commit to ninsbl/grass that referenced this issue Oct 26, 2022
@metzm @ninsbl
r.clump (OSGeo#1792)
9213e02 
With threshold=0, FCELL/DCELL maps are truncated to CELL, resulting in clumps of input cells with different values. Fixes OSGeo#1599.
ninsbl pushed a commit to ninsbl/grass that referenced this issue Feb 17, 2023
@metzm @ninsbl
r.clump (OSGeo#1792)
cbf4770 
With threshold=0, FCELL/DCELL maps are truncated to CELL, resulting in clumps of input cells with different values. Fixes OSGeo#1599.
neteler pushed a commit to nilason/grass that referenced this issue Nov 7, 2023
@metzm @neteler
r.clump (OSGeo#1792)
342a49a 
With threshold=0, FCELL/DCELL maps are truncated to CELL, resulting in clumps of input cells with different values. Fixes OSGeo#1599.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
8.0.0
Development

Successfully merging a pull request may close this issue.

r.clump: fix clumping of FCELL/DCELL maps with threshold=0 metzm/grass
2 participants
@neteler @ecodiv