python scripting lib: fix run_command(error='status') not returning 0 #1839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixes write_command error handling behavior.
wenzeslaus
approved these changes
Sep 2, 2021
This was referenced Sep 5, 2021
lindakarlovska
pushed a commit
to lindakarlovska/grass
that referenced
this pull request
Sep 6, 2021
…OSGeo#1839) With this fix run_command when called with errors='status' will always return the return code (even if completed successfully). Also fixes write_command error handling behavior.
ninsbl
pushed a commit
to ninsbl/grass
that referenced
this pull request
Oct 26, 2022
…OSGeo#1839) With this fix run_command when called with errors='status' will always return the return code (even if completed successfully). Also fixes write_command error handling behavior.
ninsbl
pushed a commit
to ninsbl/grass
that referenced
this pull request
Feb 17, 2023
…OSGeo#1839) With this fix run_command when called with errors='status' will always return the return code (even if completed successfully). Also fixes write_command error handling behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this fix run_command when called with
errors='status'will always return the return code (even if completed successfully).Also fixes write_command error handling behavior.
This should address #339 and replaces #333.