Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure: fix some autoconf-2.69 update issues (branch 7.8) #1870

Merged
merged 3 commits into from
Sep 16, 2021

Conversation

nilason
Copy link
Contributor

@nilason nilason commented Sep 15, 2021

This renames configure.in to configure.ac, the previous name has long been deprecated and became obsolete with 2.70.

Also addressed:

  • No need to set AC_CONFIG_AUX_DIR, default will do
  • Remove double quote on macro 'LOC_FP_TEST'

Addresses remaining issues after merging #1867 as reported with #560.

@nilason nilason changed the title configure: rename deprecated infile name (branch 7.8) configure: fix some autoconf-2.69 update issues (branch 7.8) Sep 16, 2021
@nilason
Copy link
Contributor Author

nilason commented Sep 16, 2021

I updated this PR's title and summary to reflect all changes needed to fix #560.

I take the liberty to merge this straight away to enable this to be tested ASAP on Windows in particular.

@nilason nilason merged commit 50e7736 into OSGeo:releasebranch_7_8 Sep 16, 2021
@nilason nilason deleted the configure-rename-infile branch September 16, 2021 19:03
@ninsbl
Copy link
Member

ninsbl commented Sep 17, 2021

With unixodbc installed in MSYS2, the build works fine without further modifications. So this looks nice with OSGeo4W-V2.

See:
https://github.com/ninsbl/grass/runs/3631639686?check_suite_focus=true
(there seem to be issues with running tests on UBUNTU, but they are probably unrelated!?)

Here is the temporary branch in my fork with the integrated changes:
https://github.com/ninsbl/grass/commits/releasebranch_7_8_osgeo4w_vs

@nilason
Copy link
Contributor Author

nilason commented Sep 21, 2021

With unixodbc installed in MSYS2, the build works fine without further modifications. So this looks nice with OSGeo4W-V2.

See:
https://github.com/ninsbl/grass/runs/3631639686?check_suite_focus=true
(there seem to be issues with running tests on UBUNTU, but they are probably unrelated!?)

Here is the temporary branch in my fork with the integrated changes:
https://github.com/ninsbl/grass/commits/releasebranch_7_8_osgeo4w_vs

#1883 addresses this for OSGeo4W-V1 as well.

@neteler neteler added this to the 7.8.6 milestone Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants