checks: Fix -Wsometimes-uninitialized compiler warnings #2165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 tasks
|
Can you please move the CodeQL errors to a separate PR? They are unrelated and likely we can merge them much sooner. |
nilason
force-pushed
the
fix_wall_warnings_09
branch
from
63880e6
to
97894c3
Compare
|
I merged this with main which resolved conflicts, but it needs some additional clean up because now it would revert some changes which happened on main in the same files. Given that this is a draft without any actual code changes, I'm leaving it as is for now. |
nilason
force-pushed
the
fix_wall_warnings_09
branch
from
80bfbe0
to
d034c1b
Compare
|
Finalised the rebase, to be able to continue with clean sheets. |
|
Opening this for review. I left the comments temporarily for context, I will remove them before merge. |
wenzeslaus
reviewed
Nov 1, 2022
|
This is now ready, I'll proceed to merge soon if there are no objections. |
marisn
approved these changes
Nov 8, 2022
ninsbl
pushed a commit
to ninsbl/grass
that referenced
this pull request
Feb 17, 2023
marisn
pushed a commit
to marisn/grass
that referenced
this pull request
Jun 2, 2023
neteler
changed the title
neteler
pushed a commit
to nilason/grass
that referenced
this pull request
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #2156.
Initially this is a draft, I commented in code to highlight the sometimes uninitialised variables.
We need to decide how to address them.
Affects:
Modules
GRASS Library parts