Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Add missing step id to release draft, pre-release, artifacts #2347

Merged
merged 2 commits into from
May 16, 2022

Conversation

wenzeslaus
Copy link
Member

@wenzeslaus wenzeslaus commented Apr 29, 2022

  • Remove new from the name (yes, we are creating a new thing, but it is a draft which says enough).
  • To use step_id for asset upload, specify id for the create release step.
  • If the tag contains RC, mark the release a pre-release.
  • On failure, upload the created file to an artifact for workflow debugging and use of the files for the release.

Known issues out of scope for this PR:

The job for 8.2.0RC1 failed with the following output which now should be fixed by the id addition:

Run actions/upload-release-asset@v1
  with:
    asset_path: core_modules_with_last_commit.json
    asset_name: core_modules_with_last_commit.json
    asset_content_type: application/json
  env:
    pythonLocation: /opt/hostedtoolcache/Python/3.10.4/x64
    LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.10.4/x64/lib
    GITHUB_TOKEN: ***
Error: Input required and not supplied: upload_url

- Remove new from the name (yes, we are creating a new thing, but it is a draft which says enough).
- To use step_id for asset upload, specify id for the create release step.
- If the tag contains RC, mark the release a pre-release.
- On failure, upload the created file to an artifact for workflow debugging and use of the files for the release.
@wenzeslaus wenzeslaus added bug Something isn't working CI Continuous integration labels Apr 29, 2022
@wenzeslaus wenzeslaus added this to the 8.2.0 milestone Apr 29, 2022
@wenzeslaus wenzeslaus requested a review from tmszi April 29, 2022 18:42
@wenzeslaus wenzeslaus merged commit fcaf315 into OSGeo:main May 16, 2022
@wenzeslaus wenzeslaus deleted the id-for-create-release branch May 16, 2022 21:15
wenzeslaus added a commit that referenced this pull request May 24, 2022
- Remove new from the name (yes, we are creating a new thing, but it is a draft which says enough).
- To use step_id for asset upload, specify id for the create release step.
- If the tag contains RC, mark the release a pre-release.
- On failure, upload the created file to an artifact for workflow debugging and use of the files for the release.
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Oct 26, 2022
…eo#2347)

- Remove new from the name (yes, we are creating a new thing, but it is a draft which says enough).
- To use step_id for asset upload, specify id for the create release step.
- If the tag contains RC, mark the release a pre-release.
- On failure, upload the created file to an artifact for workflow debugging and use of the files for the release.
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Feb 17, 2023
…eo#2347)

- Remove new from the name (yes, we are creating a new thing, but it is a draft which says enough).
- To use step_id for asset upload, specify id for the create release step.
- If the tag contains RC, mark the release a pre-release.
- On failure, upload the created file to an artifact for workflow debugging and use of the files for the release.
neteler pushed a commit to nilason/grass that referenced this pull request Nov 7, 2023
…eo#2347)

- Remove new from the name (yes, we are creating a new thing, but it is a draft which says enough).
- To use step_id for asset upload, specify id for the create release step.
- If the tag contains RC, mark the release a pre-release.
- On failure, upload the created file to an artifact for workflow debugging and use of the files for the release.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CI Continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants