Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Add missing step id to release draft, pre-release, artifacts #2347

Merged
merged 2 commits into from
May 16, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Create new release draft
name: Create a release draft

on:
push:
Expand All @@ -25,6 +25,7 @@ jobs:
git diff --cached > core_modules_with_last_commit.patch
- name: Create new release draft
id: create_release
uses: actions/create-release@v1
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Expand All @@ -36,7 +37,7 @@ jobs:
- First change
- Second change
draft: true
prerelease: false
prerelease: ${{ contains(github.ref, "RC") }}

- name: Upload core_modules_with_last_commit.json file
uses: actions/upload-release-asset@v1
Expand All @@ -57,3 +58,13 @@ jobs:
asset_path: core_modules_with_last_commit.patch
asset_name: core_modules_with_last_commit.patch
asset_content_type: text/plain

- name: On failure, make the created files available
uses: actions/upload-artifact@v3
if: failure()
with:
name: artifacts
path: |
core_modules_with_last_commit.*
if-no-files-found: warn
retention-days: 10