r.blend: Quote map names in r.mapcalc expressions. #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoids failure if map / mapset name is also a valid mathematical expression.
|
Same issue also affects r.grow. Fixed with 81761a8 |
|
To better try it out, do you have a (simple) example? |
Hmmm. This could be a good addition to the test suite, as there could be errors in other modules as well. Still I'm not that familiar with the test suite to understand how to force running all tests in a specific mapset.
|
|
I have written a testsuite script in PR #347, pls check |
neteler
added a commit
that referenced
this pull request
Feb 18, 2020
* testsuite: r.blend quoting test Added test script which implements the test suggested in PR #277 Co-authored-by: Māris Nartišs <mn@sungis.lv>
neteler
added a commit
that referenced
this pull request
Feb 18, 2020
* testsuite: r.blend quoting test Added test script which implements the test suggested in PR #277 Co-authored-by: Māris Nartišs <mn@sungis.lv>
|
An objections to merge and backport? |
No one seems to object. I can rebase, if needed. |
landam
approved these changes
Mar 20, 2020
|
@neteler Are you planning to merge it? |
neteler
pushed a commit
that referenced
this pull request
Mar 20, 2020
* r.blend: Quote map names in r.mapcalc expressions. Avoids failure if map / mapset name is also a valid mathematical expression. * r.grow: Quote map names in mapcalc expression * testsuite: r.grow test case for mapcalc map quoting. Based on PR #347 and PR #277 Co-authored-by: Māris Nartišs <maris.nartiss@lu.lv>
Done and backported |
HuidaeCho
pushed a commit
to HuidaeCho/grass
that referenced
this pull request
Mar 20, 2020
* r.blend: Quote map names in r.mapcalc expressions. Avoids failure if map / mapset name is also a valid mathematical expression. * r.grow: Quote map names in mapcalc expression * testsuite: r.grow test case for mapcalc map quoting. Based on PR OSGeo#347 and PR OSGeo#277 Co-authored-by: Māris Nartišs <maris.nartiss@lu.lv>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids failure if map / mapset name is also a valid mathematical expression.