r.grow: Correctly handle shrinking of maps without NULL values #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me, seems like a bugfix that should be backported. |
|
A testsuite script could be rather easily derived from PR #347, pls check |
marisn
added a commit
to marisn/grass
that referenced
this pull request
Feb 18, 2020
…es in the input. Fixes r.grow producing empty maps on shrink.
marisn
force-pushed
the
r_grow_null_fix
branch
from
788758a
to
84eb245
Compare
|
@marisn Time for merge? |
Whenever you ready. I can rebase, if needed. |
neteler
pushed a commit
that referenced
this pull request
Mar 20, 2020
* r.grow: Output unchanged map when shrinking if there are no null values in the input. Fixes r.grow producing empty maps on shrink. * testsuite: r.grow test shrinking map without NULL values Based on PR #343 Co-authored-by: Māris Nartišs <maris.nartiss@lu.lv>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If r.grow shrinking (negative distance) is performed on a map without NULL values, output is all NULL, although it should be identical to input. With this PR, shrinking of a map without NULL values will produce output equal to input.
Should be applied on top of PR #277