Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wxGUI: Fix Python and wxPython deprecations #2827

Merged
merged 3 commits into from
Feb 15, 2023

Conversation

nilason
Copy link
Contributor

@nilason nilason commented Feb 14, 2023

Fixes some Python deprecation warnings:

  • invalid escape sequence
  • Menu.Append() is deprecated

I came across these warnings and fixed them in November last year, I therefore can't remember versions involved, but I believe it was Python 3.10 and wxPython 4.2.

@nilason nilason added enhancement New feature or request Python Related code is in Python labels Feb 14, 2023
@nilason nilason added this to the 8.3.0 milestone Feb 14, 2023
@nilason nilason merged commit ab64b01 into OSGeo:main Feb 15, 2023
@nilason nilason deleted the fix_python_deprecations branch February 15, 2023 09:30
@nilason
Copy link
Contributor Author

nilason commented Feb 15, 2023

This apparently introduced some regression. I'm looking into it.

@wenzeslaus
Copy link
Member

To avoid cases like this and #2721 in the future, selected tests are now mandatory to pass before merging.

nilason added a commit to nilason/grass that referenced this pull request Feb 15, 2023
@nilason
Copy link
Contributor Author

nilason commented Feb 15, 2023

To avoid cases like this and #2721 in the future, selected tests are now mandatory to pass before merging.

If I only paid attention to the tests... Really sorry for this one, sloppy work from my side. #2830 will hopefully fix this.

nilason added a commit that referenced this pull request Feb 15, 2023
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Feb 17, 2023
Addresses following Python deprecation warnings:
* "DeprecationWarning: invalid escape sequence"
* "DeprecationWarning: Menu.Append() is deprecated"
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Feb 17, 2023
@wenzeslaus wenzeslaus changed the title Fix Python deprecations wxGUI: Fix Python and wxPython deprecations Jun 6, 2023
neteler pushed a commit to nilason/grass that referenced this pull request Nov 7, 2023
Addresses following Python deprecation warnings:
* "DeprecationWarning: invalid escape sequence"
* "DeprecationWarning: Menu.Append() is deprecated"
neteler pushed a commit to nilason/grass that referenced this pull request Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Python Related code is in Python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants