grass.script: Revert raw string from #2827 to byte string #2830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes regression caused by OSGeo#2827
|
This makes sense since the input to convert_xml_to_utf8 is binary string from Popen.communicate, but I wonder what was the original reason for the change? |
That was made some time ago, so I don't remember this one specifically. Probably I searched for regex patterns without raw literal strings and "happened" to change this one too. |
petrasovaa
approved these changes
Feb 15, 2023
|
Merged. Again, sorry for messing up! |
ninsbl
pushed a commit
to ninsbl/grass
that referenced
this pull request
Feb 17, 2023
Fixes regression caused by OSGeo#2827
wenzeslaus
changed the title
neteler
pushed a commit
to nilason/grass
that referenced
this pull request
Nov 7, 2023
Fixes regression caused by OSGeo#2827
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes regression caused by #2827.