Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version: Replace references to 8.2 #2969

Merged
merged 4 commits into from
May 1, 2024
Merged

Conversation

wenzeslaus
Copy link
Member

@wenzeslaus wenzeslaus commented May 17, 2023

  • Links to latest (current) stable in notebooks use the grass-stable URL.
  • singularity: Use tag instead of branch. Use an old tag for the example. Avoid using version in the image name.

8.2 used in examples (no change needed?):

  • lib/init/grass.html

Fix based on updates to 8.3 branch (same text or same style):

@wenzeslaus wenzeslaus added this to the 8.4.0 milestone May 18, 2023
@wenzeslaus wenzeslaus added the bug Something isn't working label Sep 18, 2023
@landam
Copy link
Member

landam commented Nov 19, 2023

@wenzeslaus Still relevant?

@wenzeslaus
Copy link
Member Author

Yes, this is still relevant. There are two questions in the description which I don't know an answer to.

In lib/init/grass.html, version number is in example of possible values --config. Other values are old dates (2020) or hashes and that seems to be just fine. What to do with version number for GRASS GIS?

For general/g.version/g.version.html, the version is in several examples of output from g.version. The context is similar - other versions, dates, and hashes. How to modify this if at all?

Do want to keep updating these with every version? Elsewhere, we were able to reduce these updates (see this PR for examples) and thus reduce the work needed for every release.

- Links to latest (current) stable in notebooks use the grass-stable URL.
- singularity: Use tag instead of branch. Use an old tag for the example.

Missing or need to be resolved elsewhere: eneral/g.version/g.version.html rpm/grass.spec doc/howto_release.md doc/development/submitting/general.md lib/init/grass.html
@wenzeslaus wenzeslaus marked this pull request as ready for review April 27, 2024 01:16
@github-actions github-actions bot added HTML Related code is in HTML libraries module general labels Apr 27, 2024
@wenzeslaus
Copy link
Member Author

Given the lack of ideas and suggestions here, I just updated the numbers from 8.2 to 8.4. I was trying to avoid these changes elsewhere because these need to be updated with each release. I fixed some dates, years and dropped the dev suffix.

This is now ready for review and inclusion into 8.4.

@wenzeslaus wenzeslaus requested a review from neteler April 30, 2024 14:09
Copy link
Member

@neteler neteler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

@echoix echoix merged commit 305f692 into OSGeo:main May 1, 2024
26 checks passed
HuidaeCho pushed a commit to HuidaeCho/grass that referenced this pull request May 21, 2024
* version: Replace references to 8.2

- Links to latest (current) stable in notebooks use the grass-stable URL.
- singularity: Use tag instead of branch. Use an old tag for the example.

Missing or need to be resolved elsewhere: general/g.version/g.version.html rpm/grass.spec doc/howto_release.md doc/development/submitting/general.md lib/init/grass.html

* Update to 8.4.0 and new format for date for grass.html

* Update to 8.4.0 and 2024 for g.version

* Checkout "{tag or branch}" not 8.2.0 in an example.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working docs general HTML Related code is in HTML libraries linux Linux specific module notebook
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants