contributing: Align backporting example with text #2978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The first part of the paragraph talks about backporting to all branches in between main and furthest backport. However, the example pushed the idea of backport to the furthest instead. The new example is now only about backporting to the in-between branch. The new example uses version numbers with the major version 3 because it is only an example, so it does not need to be updated.
7 tasks
I guess this should be in a separate PR. |
An in fact it is: #2977. I must have used that branch instead of main to create this one branch. I'll just revert that commit. |
wenzeslaus
changed the title
This reverts commit 7618656.
|
Reverted and the description updated accordingly. |
neteler
reviewed
May 23, 2023
…thier number and simplify the example by addressing the default choice at the beginning of the pragraph
|
This is ready for review. (The conversation can be resolved, too.) |
jadenabrams100
pushed a commit
to ncsu-csc472-spring2024/grass-CI-playground
that referenced
this pull request
Feb 21, 2024
The first part of the paragraph talks about backporting to all branches in between main and furthest backport. However, the example pushed the idea of backport to the furthest instead. The new example is now only about backporting to the in-between branch while the paragraph addresses the backport in general and packport to the closest branch first. The new example uses version numbers with the major version 3 because it is only an example, so it does not need to be updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first part of the paragraph talks about backporting to all branches in between main and furthest backport. However, the example pushed the idea of backport to the furthest instead. The new example is now only about backporting to the in-between branch while the paragraph addresses the backport in general and packport to the closest branch first.
The new example uses version numbers with the major version 3 because it is only an example, so it does not need to be updated.