Py2/Py3 compat: Use "gettext.install(..., unicode=True)" in Python 2. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`unicode` is no longer a valid keyword for `gettext.install()` in Python 3 but we need it on Python 2. This is in continuation of https://trac.osgeo.org/grass/changeset/74307 which was a fix for: https://trac.osgeo.org/grass/ticket/3790 Fixes https://trac.osgeo.org/grass/ticket/3838
wenzeslaus
requested changes
May 24, 2019
There was a problem hiding this comment.
As I said in https://trac.osgeo.org/grass/ticket/3790, I think https://trac.osgeo.org/grass/changeset/74307 should be reverted because:
- It is still unclear if there is something left in https://trac.osgeo.org/grass/ticket/3838 which is caused by 74307 (https://trac.osgeo.org/grass/ticket/3838#comment:12)
- It does not take into account https://trac.osgeo.org/grass/ticket/1739 and https://trac.osgeo.org/grass/ticket/2425 and it is not following the recommendations for libraries.
- It seems that it is trying to fix something else, so the question is if other change is not more appropriate to solve that (https://trac.osgeo.org/grass/ticket/3790#comment:5, https://trac.osgeo.org/grass/ticket/3772)
I don't know how these changes would be applicable with 74307 reverted. It is okay as a quick fix for part of 3838, but I would prefer this being revisited from the beginning, esp. if we are trying to make the grass package behave like a generally usable Python package.
This PR contains the patch that @marisn confirmed that solves 3838. WRT to the traceback that is mentioned on comment 12, I still haven't heard from @marisn, but I did try to reproduce it and I could not. If someone can offer clear instructions on how to reproduce the issue, I will be happy to look into it. BTW, the traceback is incomplete, so it is not easy to understand what is the problem, but from what I can tell, it does not seem to be related to gettext. That being said, the other points should probably be discussed on a separate issue or on the ML. |
petrasovaa
approved these changes
May 29, 2019
wenzeslaus
approved these changes
May 29, 2019
|
Please merge the PR. |
landam
added a commit
to landam/grass
that referenced
this pull request
Jul 26, 2019
landam
added a commit
to landam/grass
that referenced
this pull request
Jul 26, 2019
landam
added a commit
to ctu-geoforall-lab/grass
that referenced
this pull request
Jun 10, 2020
landam
pushed a commit
to ctu-geoforall-lab/grass
that referenced
this pull request
Jun 10, 2020
Change of input arguments, and adding test. OSGeo#3 Co-Authored-By: dekanluc <dekanluc@users.noreply.github.com>
echoix
added a commit
that referenced
this pull request
Jun 19, 2024
* CI: Switch Travis to Ubuntu 22.04 (jammmy) Default Python version reported by Travis for 20.04 is 3.7.13. While that's still a supported version for 8.3 release if it would be released now, 2023-06-27 is end of support for 3.7, so it seems safe to not test the main branch with 3.7 at this point. Ubuntu 22.04 in Travis uses Python 3.10 by default according to the documentation. * Update wxgtk pkg to 4.0 * Replace custom install list by apt.txt file from GitHub Actions * Change shebang to use bash instead of POSIX sh (#3) * CI(travis): Add --with-pdal in linux.script.sh * CI(travis): Remove sudo: required as it has no effect * CI(travis): Fix warning os and dist missing from root * CI(travis): Fix warning matrix is an alias for jobs * CI(travis): Run make with make -j $(nproc) * CI(travis): Show MAKEFLAGS at start of script * CI(travis): use c++17 standard * CI(travis): Remove duplicated dist key in include array * CI(travis): Remove invalid --with-python from configure flags * CI(travis): Remove unused codecov upload * CI(travis): Remove irc notification * CI(travis): Add -Werror and -fPIC to CFLAGS and CXXFLAGS on make call * CI(travis): Limit runs on branches to main and release branches * CI(travis): Add -Wfatal-errors * db: Fix -Wdeprecated-non-prototype in describe.c for clang builds * CI(travis): Add --no-keep-going in MAKEFLAGS to stop on errors * db: Fix -Wdeprecated-non-prototype in odbc driver's fetch.c for clang builds * db: Fix -Wdeprecated-non-prototype in odbc driver's listtab.c for clang builds --------- Co-authored-by: Edouard Choinière <27212526+echoix@users.noreply.github.com>
kritibirda26
pushed a commit
to kritibirda26/grass
that referenced
this pull request
Jun 29, 2024
…o#3002) * CI: Switch Travis to Ubuntu 22.04 (jammmy) Default Python version reported by Travis for 20.04 is 3.7.13. While that's still a supported version for 8.3 release if it would be released now, 2023-06-27 is end of support for 3.7, so it seems safe to not test the main branch with 3.7 at this point. Ubuntu 22.04 in Travis uses Python 3.10 by default according to the documentation. * Update wxgtk pkg to 4.0 * Replace custom install list by apt.txt file from GitHub Actions * Change shebang to use bash instead of POSIX sh (OSGeo#3) * CI(travis): Add --with-pdal in linux.script.sh * CI(travis): Remove sudo: required as it has no effect * CI(travis): Fix warning os and dist missing from root * CI(travis): Fix warning matrix is an alias for jobs * CI(travis): Run make with make -j $(nproc) * CI(travis): Show MAKEFLAGS at start of script * CI(travis): use c++17 standard * CI(travis): Remove duplicated dist key in include array * CI(travis): Remove invalid --with-python from configure flags * CI(travis): Remove unused codecov upload * CI(travis): Remove irc notification * CI(travis): Add -Werror and -fPIC to CFLAGS and CXXFLAGS on make call * CI(travis): Limit runs on branches to main and release branches * CI(travis): Add -Wfatal-errors * db: Fix -Wdeprecated-non-prototype in describe.c for clang builds * CI(travis): Add --no-keep-going in MAKEFLAGS to stop on errors * db: Fix -Wdeprecated-non-prototype in odbc driver's fetch.c for clang builds * db: Fix -Wdeprecated-non-prototype in odbc driver's listtab.c for clang builds --------- Co-authored-by: Edouard Choinière <27212526+echoix@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unicodeis no longer a valid keyword forgettext.install()in Python 3but we need it on Python 2.
This is in continuation of https://trac.osgeo.org/grass/changeset/74307
which was a fix for: https://trac.osgeo.org/grass/ticket/3790
Fixes https://trac.osgeo.org/grass/ticket/3838