g.download.project: rename g.download.location #4187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
CI
echoix
previously approved these changes
Aug 16, 2024
There was a problem hiding this comment.
Looks good, assuming that the old contents of g.download.location were copied to g.download.project without hidden changes. The some docstrings could be changed later (more reviewable diff) to change location->project when needed.
The old g.download.location calls the new g.download.project, looks fine.
Html docs are also updated.
|
Please merge #4155 first. |
|
Is #4155 almost ready, or ready? |
|
@petrasovaa there is a conflict, but the change(s) from #4155 might need to be applied to a different file. It needs more than what the web interface offers to do it right. |
petrasovaa
force-pushed
the
g.download.project
branch
from
04071df
to
79db0bc
Compare
echoix
approved these changes
Aug 20, 2024
|
@petrasovaa Do you want this to be backported to G8.4? For now it landed in G8.5. |
|
Right, done. |
landam
pushed a commit
to landam/grass
that referenced
this pull request
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To continue with the location to project renaming, this PR is renaming g.download.location to g.download.project. For backwards compatibility I left g.download.location that calls g.download.project.
My suggestion is to add a warning to g.download.location in/after 8.5 and remove it completely for GRASS 9.