Code quality fixes for grass package (lib/python) #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing by actually moving imports (hashlib), moving the non-importing code down after the imports (matplotlib.use and Python 2/3 variables). Several files ignored using the per-file-ignores. These may or may not be substantiated as exceptions, so keeping them in the config file rather than in the file itself to have here a clear warning that the check was disabled. In general E402 should be fixable by moving code around and couple inline ignores like in the case of matplotlib.use in gunittest/multireport.
Now all checks for Python 3 which are using sys.version_info.major are using >= operator because we are actually interested in 'not Python 2' and we assume Python 4 will behave more like Python 3 and not like Python 2.
This seems to mostly report things imported twice.
NotImplemented is a constant for implementing binary special methods. NotImplementedError is an exception indicating real implementation still needs to be added.
Lambdas are for embedding into larger expressions. When assigned, it is just a strange syntax for a function definition because def can appear anywhere in the code already.
ninsbl
approved these changes
May 3, 2020
|
Thank you. Reading is all I expected. I think it is sufficient and here possibly more reliable than testing it (what to test would be quite tricky to determine in some cases). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes Flake8 errors/warnings:
And additionally it unifies checks for Python 3 using sys.version_info.major.
I also moved serious errors to be resolved up in the Flake8 configuration file and whitespace errors down.
For review, you can check the changes in individual commits one by one.